From 473ab686505f3181103ded51be1805a8666d7321 Mon Sep 17 00:00:00 2001 From: Jeff Brown Date: Fri, 4 Jan 2013 07:55:45 -0600 Subject: [PATCH 1/6] GRAILS-3463 - test for passing null to dynamic finder multiple times --- .../grails/orm/hibernate/FindByMethodTests.groovy | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/grails-test-suite-persistence/src/test/groovy/org/codehaus/groovy/grails/orm/hibernate/FindByMethodTests.groovy b/grails-test-suite-persistence/src/test/groovy/org/codehaus/groovy/grails/orm/hibernate/FindByMethodTests.groovy index f4685f926c6..8dda8ad19c3 100644 --- a/grails-test-suite-persistence/src/test/groovy/org/codehaus/groovy/grails/orm/hibernate/FindByMethodTests.groovy +++ b/grails-test-suite-persistence/src/test/groovy/org/codehaus/groovy/grails/orm/hibernate/FindByMethodTests.groovy @@ -1,6 +1,7 @@ package org.codehaus.groovy.grails.orm.hibernate import grails.persistence.Entity +import groovy.transform.NotYetImplemented /** * @author Graeme Rocher @@ -11,6 +12,15 @@ class FindByMethodTests extends AbstractGrailsHibernateTests { protected getDomainClasses() { [FindByMethodBook, FindByMethodUser, FindByBooleanPropertyBook, Highway, Person, Pet, Face, Nose] } + + @NotYetImplemented + void testNullAsSoleParameter() { + def bookClass = ga.getDomainClass(FindByMethodBook.name).clazz + assertNotNull bookClass.findAllByReleaseDate(null) + + // per GRAILS-3463, this second call was throwing MissingMethodException + assertNotNull bookClass.findAllByReleaseDate(null) + } void testNullParameters() { def bookClass = ga.getDomainClass(FindByMethodBook.name).clazz From cd29a12bcca614f3e6a9e908b1f151de55df3827 Mon Sep 17 00:00:00 2001 From: Jeff Brown Date: Fri, 4 Jan 2013 07:56:10 -0600 Subject: [PATCH 2/6] use g-d-m 1.1.4.BUILD-SNAPSHOT --- build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.gradle b/build.gradle index dc5321a9e4f..7d355a2ce0b 100644 --- a/build.gradle +++ b/build.gradle @@ -24,7 +24,7 @@ ext { commonsCollectionsVersion = "3.2.1" commonsIOVersion = "2.1" commonsLangVersion = "2.6" - datastoreVersion = "1.1.2.RELEASE" + datastoreVersion = "1.1.4.BUILD-SNAPSHOT" gantVersion = "1.9.6" gdocEngineVersion = "1.0.1" groovyVersion = "2.0.5" From 49eaf6e96c765b7d80f75145cffe207cdb406276 Mon Sep 17 00:00:00 2001 From: Jeff Brown Date: Fri, 4 Jan 2013 07:57:47 -0600 Subject: [PATCH 3/6] GRAILS-3463 - remove @NotYetImplemented --- .../groovy/grails/orm/hibernate/FindByMethodTests.groovy | 2 -- 1 file changed, 2 deletions(-) diff --git a/grails-test-suite-persistence/src/test/groovy/org/codehaus/groovy/grails/orm/hibernate/FindByMethodTests.groovy b/grails-test-suite-persistence/src/test/groovy/org/codehaus/groovy/grails/orm/hibernate/FindByMethodTests.groovy index 8dda8ad19c3..fc076982a42 100644 --- a/grails-test-suite-persistence/src/test/groovy/org/codehaus/groovy/grails/orm/hibernate/FindByMethodTests.groovy +++ b/grails-test-suite-persistence/src/test/groovy/org/codehaus/groovy/grails/orm/hibernate/FindByMethodTests.groovy @@ -1,7 +1,6 @@ package org.codehaus.groovy.grails.orm.hibernate import grails.persistence.Entity -import groovy.transform.NotYetImplemented /** * @author Graeme Rocher @@ -13,7 +12,6 @@ class FindByMethodTests extends AbstractGrailsHibernateTests { [FindByMethodBook, FindByMethodUser, FindByBooleanPropertyBook, Highway, Person, Pet, Face, Nose] } - @NotYetImplemented void testNullAsSoleParameter() { def bookClass = ga.getDomainClass(FindByMethodBook.name).clazz assertNotNull bookClass.findAllByReleaseDate(null) From 7575a07fe5d8b9c53d0a282db44f771b5d07714d Mon Sep 17 00:00:00 2001 From: Jeff Brown Date: Fri, 4 Jan 2013 07:55:45 -0600 Subject: [PATCH 4/6] GRAILS-3463 - test for passing null to dynamic finder multiple times --- .../grails/orm/hibernate/FindByMethodTests.groovy | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/grails-test-suite-persistence/src/test/groovy/org/codehaus/groovy/grails/orm/hibernate/FindByMethodTests.groovy b/grails-test-suite-persistence/src/test/groovy/org/codehaus/groovy/grails/orm/hibernate/FindByMethodTests.groovy index 6bca3737fe9..e30d4529f47 100644 --- a/grails-test-suite-persistence/src/test/groovy/org/codehaus/groovy/grails/orm/hibernate/FindByMethodTests.groovy +++ b/grails-test-suite-persistence/src/test/groovy/org/codehaus/groovy/grails/orm/hibernate/FindByMethodTests.groovy @@ -1,6 +1,7 @@ package org.codehaus.groovy.grails.orm.hibernate import grails.persistence.Entity +import groovy.transform.NotYetImplemented /** * @author Graeme Rocher @@ -11,6 +12,15 @@ class FindByMethodTests extends AbstractGrailsHibernateTests { protected getDomainClasses() { [FindByMethodBook, FindByMethodUser, FindByBooleanPropertyBook, Highway, Person, Pet] } + + @NotYetImplemented + void testNullAsSoleParameter() { + def bookClass = ga.getDomainClass(FindByMethodBook.name).clazz + assertNotNull bookClass.findAllByReleaseDate(null) + + // per GRAILS-3463, this second call was throwing MissingMethodException + assertNotNull bookClass.findAllByReleaseDate(null) + } void testNullParameters() { def bookClass = ga.getDomainClass(FindByMethodBook.name).clazz From 7c3781a014ee8a1101cbec9b0b154e9670e73e2f Mon Sep 17 00:00:00 2001 From: Jeff Brown Date: Fri, 4 Jan 2013 07:56:10 -0600 Subject: [PATCH 5/6] use g-d-m 1.1.4.BUILD-SNAPSHOT --- build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.gradle b/build.gradle index 3f770bd6d49..b4d6850c6bb 100644 --- a/build.gradle +++ b/build.gradle @@ -24,7 +24,7 @@ ext { commonsCollectionsVersion = "3.2.1" commonsIOVersion = "2.1" commonsLangVersion = "2.6" - datastoreVersion = "1.1.2.RELEASE" + datastoreVersion = "1.1.4.BUILD-SNAPSHOT" gantVersion = "1.9.6" gdocEngineVersion = "1.0.1" groovyVersion = "1.8.8" From 2074227ddd0c3a19a8630db36d7b528eb0c09f8a Mon Sep 17 00:00:00 2001 From: Jeff Brown Date: Fri, 4 Jan 2013 07:57:47 -0600 Subject: [PATCH 6/6] GRAILS-3463 - remove @NotYetImplemented --- .../groovy/grails/orm/hibernate/FindByMethodTests.groovy | 2 -- 1 file changed, 2 deletions(-) diff --git a/grails-test-suite-persistence/src/test/groovy/org/codehaus/groovy/grails/orm/hibernate/FindByMethodTests.groovy b/grails-test-suite-persistence/src/test/groovy/org/codehaus/groovy/grails/orm/hibernate/FindByMethodTests.groovy index e30d4529f47..847d65f72da 100644 --- a/grails-test-suite-persistence/src/test/groovy/org/codehaus/groovy/grails/orm/hibernate/FindByMethodTests.groovy +++ b/grails-test-suite-persistence/src/test/groovy/org/codehaus/groovy/grails/orm/hibernate/FindByMethodTests.groovy @@ -1,7 +1,6 @@ package org.codehaus.groovy.grails.orm.hibernate import grails.persistence.Entity -import groovy.transform.NotYetImplemented /** * @author Graeme Rocher @@ -13,7 +12,6 @@ class FindByMethodTests extends AbstractGrailsHibernateTests { [FindByMethodBook, FindByMethodUser, FindByBooleanPropertyBook, Highway, Person, Pet] } - @NotYetImplemented void testNullAsSoleParameter() { def bookClass = ga.getDomainClass(FindByMethodBook.name).clazz assertNotNull bookClass.findAllByReleaseDate(null)