Skip to content
Browse files

build warnings

  • Loading branch information...
1 parent 122a34a commit ba30cbaecfeb2da355206dbc8242dbdc9e64c9f4 @burtbeckwith burtbeckwith committed
View
2 grails-core/src/main/groovy/org/codehaus/groovy/grails/commons/DefaultGrailsApplication.java
@@ -741,7 +741,7 @@ public ArtefactInfo getArtefactInfo(String artefactType) {
* @param methodName The name of the method
* @param args The arguments to the method
* @return The return value of the method
- * @todo Need to add matches for add<Artefact>Class(java.lang.Class) and add<Artefact>Class(GrailsClass)
+ * TODO Need to add matches for add<Artefact>Class(java.lang.Class) and add<Artefact>Class(GrailsClass)
*/
@Override
public Object invokeMethod(String methodName, Object args) {
View
2 grails-core/src/main/groovy/org/codehaus/groovy/grails/commons/GrailsApplication.java
@@ -228,7 +228,7 @@
/**
* Rebuilds the constraint definitions.
- * @todo move this out? Why ORM dependencies in here?
+ * TODO move this out? Why ORM dependencies in here?
*/
void refreshConstraints();
View
4 ...ontrollers/src/main/groovy/org/codehaus/groovy/grails/plugins/web/api/ControllersApi.java
@@ -209,10 +209,10 @@ public boolean hasErrors(Object instance) {
}
/**
- * Redirects for the given arguments
+ * Redirects for the given arguments.
*
* @param args The arguments
- * @return
+ * @return null
*/
public Object redirect(Object instance,Map args) {
return redirect.invoke(instance, "redirect", new Object[]{ args });
View
2 ...n/groovy/org/codehaus/groovy/grails/commons/spring/DefaultRuntimeSpringConfiguration.java
@@ -62,7 +62,7 @@
/**
* Creates the ApplicationContext instance. Subclasses can override to customise the used ApplicationContext
*
- * @param parent The parent ApplicationContext instance. Can be null.
+ * @param parentCtx The parent ApplicationContext instance. Can be null.
*
* @return An instance of GenericApplicationContext
*/
View
2 ...org/codehaus/groovy/grails/commons/spring/TypeSpecifyableTransactionProxyFactoryBean.java
@@ -26,7 +26,7 @@
* factory has instantiated the underlying service and is able to determine it's class. This
* class allows the type to be explicitly specified.
*
- * @see org.codehaus.groovy.grails.plugins.services.ServicesGrailsPlugin
+ * Used by org.codehaus.groovy.grails.plugins.services.ServicesGrailsPlugin.
*/
@SuppressWarnings("serial")
public class TypeSpecifyableTransactionProxyFactoryBean extends TransactionProxyFactoryBean implements FactoryBean<Object> {
View
15 ...t/src/main/groovy/org/codehaus/groovy/grails/plugins/testing/GrailsMockMultipartFile.java
@@ -25,8 +25,6 @@
* Extends the default Spring MockMultipartFile to provide an implementation of transferTo that
* doesn't use the file system.
*
- * {@inheritDoc}
- *
* @author Graeme Rocher
* @since 1.4
*/
@@ -34,31 +32,18 @@
private File targetFileLocation;
-
- /**
- * {@inheritDoc}
- */
public GrailsMockMultipartFile(String name, byte[] content) {
super(name, content);
}
- /**
- * {@inheritDoc}
- */
public GrailsMockMultipartFile(String name, InputStream contentStream) throws IOException {
super(name, contentStream);
}
- /**
- * {@inheritDoc}
- */
public GrailsMockMultipartFile(String name, String originalFilename, String contentType, byte[] content) {
super(name, originalFilename, contentType, content);
}
- /**
- * {@inheritDoc}
- */
public GrailsMockMultipartFile(String name, String originalFilename, String contentType, InputStream contentStream) throws IOException {
super(name, originalFilename, contentType, contentStream);
}
View
2 grails-web/src/main/groovy/org/codehaus/groovy/grails/web/context/GrailsConfigUtils.java
@@ -171,7 +171,7 @@ public static GrailsRuntimeConfigurator determineGrailsRuntimeConfiguratorFromSe
*
* @param application
* @param propertyName
- * @return
+ * @return true if the Config parameter is true or the System property with the same name is true
*/
public static boolean isConfigTrue(GrailsApplication application, String propertyName) {
return ((application != null && application.getFlatConfig() != null && DefaultTypeTransformation.castToBoolean(application.getFlatConfig().get(propertyName))) ||
View
4 grails-web/src/main/groovy/org/codehaus/groovy/grails/web/sitemesh/GSPSitemeshPage.java
@@ -30,7 +30,7 @@
* g:capture* tags in RenderTagLib are used to capture head, meta, title, component & body contents.
* No html parsing is required for templating since capture tags are added at GSP compilation time.
*
- * @see SitemeshPreprocessor
+ * @see org.codehaus.groovy.grails.web.pages.SitemeshPreprocessor
* @author Lari Hotari, Sagire Software Oy
*/
public class GSPSitemeshPage extends AbstractHTMLPage implements Content{
@@ -159,7 +159,7 @@ public void setContentBuffer(String tagName, StreamCharBuffer buffer) {
/**
* @param name propertyName of contentBuffer (with "page." prefix)
- * @return
+ * @return the buffer for the specified name
*/
public Object getContentBuffer(String name) {
if (contentBuffers == null) {
View
2 grails-web/src/main/groovy/org/codehaus/groovy/grails/web/taglib/GroovySyntaxTag.java
@@ -95,7 +95,7 @@ public void setAttribute(String name, Object value) {
* <p>Tags must return the correct value to indicate whether or not non-whitespace content is permitted before this tag.</p>
* <p>This is for tags that must follow other tags, such as g:else or g:elseif that do not allow content between them and the
* previous tag. It is simply used as a safety mechanism to trap incorrect usage of tags.</p>
- * @todo rework this and combine with isKeepPrecedingWhiteSpace as really they are used in the same situations
+ * TODO rework this and combine with isKeepPrecedingWhiteSpace as really they are used in the same situations
* @return True if any content is allowed immediately before the tag - false if it is an error to have such content before it
*/
public abstract boolean isAllowPrecedingContent();
View
1 grails-web/src/main/groovy/org/codehaus/groovy/grails/web/transform/LineNumber.java
@@ -24,7 +24,6 @@
/**
* @author Andrew Eisenberg
- * @created Jul 22, 2010
*/
@Retention(RetentionPolicy.SOURCE)
@Target({ ElementType.TYPE })
View
1 grails-web/src/main/groovy/org/codehaus/groovy/grails/web/transform/LineNumberTransform.java
@@ -71,7 +71,6 @@
* into the line number array in the {@link LineNumber} annotation.
*
* @author Andrew Eisenberg
- * @created Jul 22, 2010
*/
@GroovyASTTransformation(phase=CompilePhase.SEMANTIC_ANALYSIS)
public class LineNumberTransform implements ASTTransformation {
View
17 grails-web/src/main/groovy/org/codehaus/groovy/grails/web/util/StreamCharBuffer.java
@@ -112,7 +112,7 @@
* <p>
* By using the "connectTo" method, one can connect the buffer directly to a
* target java.io.Writer. The internal buffer gets flushed automaticly to the
- * target whenever the buffer gets filled up. {@see #connectTo(Writer)}
+ * target whenever the buffer gets filled up. See connectTo(Writer).
* </p>
*
* <p>
@@ -456,8 +456,8 @@ public Writer writeTo(Writer target) throws IOException {
* Writes the buffer content to a target java.io.Writer
*
* @param target Writer
- * @param flushAll flush all content in buffer (if this is false, only filled chunks will be written)
* @param flushTarget calls target.flush() before finishing
+ * @param emptyAfter empties the buffer if true
* @throws IOException
*/
public void writeTo(Writer target, boolean flushTarget, boolean emptyAfter) throws IOException {
@@ -535,8 +535,9 @@ public String readAsString() {
}
/**
- * Reads (and empties) the buffer to a String, but caches the return value for subsequent calls.
+ * {@inheritDoc}
*
+ * Reads (and empties) the buffer to a String, but caches the return value for subsequent calls.
* If more content has been added between 2 calls, the returned value will be joined from the previously cached value and the data read from the buffer.
*
* @see java.lang.Object#toString()
@@ -561,7 +562,9 @@ public String toString() {
}
/**
- * hashCode() uses String's hashCode to support compatibility with String instances in maps, sets, etc.
+ * {@inheritDoc}
+ *
+ * Uses String's hashCode to support compatibility with String instances in maps, sets, etc.
*
* @see java.lang.Object#hashCode()
*/
@@ -1751,9 +1754,6 @@ void notifyBufferChange() {
}
}
- /**
- * @see java.io.Externalizable#readExternal(java.io.ObjectInput)
- */
public void readExternal(ObjectInput in) throws IOException,
ClassNotFoundException {
String str=in.readUTF();
@@ -1763,9 +1763,6 @@ public void readExternal(ObjectInput in) throws IOException,
}
}
- /**
- * @see java.io.Externalizable#writeExternal(java.io.ObjectOutput)
- */
public void writeExternal(ObjectOutput out) throws IOException {
String str=toString();
out.writeUTF(str);

0 comments on commit ba30cba

Please sign in to comment.
Something went wrong with that request. Please try again.