Permalink
Switch branches/tags
Commits on Jun 13, 2014
  1. Remove @Ignore from some tests

    jeffbrown committed Jun 13, 2014
  2. interceptor methods should be private

    jeffbrown committed Jun 13, 2014
     This should fix the failing JDK8 joint build test.  The issue is that since these methods were public they were being configured as controller actions.  This happened to work ok with JDK7 and not work with JDK8 because of a difference in the ordering of AST transformation classes at compile time.
    
     When a controller is compiled with JDK7, the getRequest method that we add to that controller looks like this...
    
        public HttpServletRequest getRequest() {
            return this.instanceControllerTagLibraryApi.getRequest(this);
        }
    
    When that same controller is compiled with JDK8 that method looks like this...
    
        public HttpServletRequest getRequest() {
            return this.instanceControllersRestApi.getRequest(this);
        }
    
    instanceControllerTagLibraryApi is initialized in the constructor.  instanceControllersRestApi is not, at least not directly.  I think it relies on injection from the app context and that bean doesn't exist when that particular failing test is run.
    
    Since these methods were being configured as controller action methods code was being added to them to access the request in order to do allowedMethods checking.  Because instanceControllersRestApi is used when the controller is compiled with JDK8 and that property is null for this particular test, the test was failing.
  3. Merge branch '2.3.x' of github.com:grails/grails-core into 2.3.x

    graemerocher committed Jun 13, 2014
    Conflicts:
    	grails-bootstrap/src/main/groovy/org/codehaus/groovy/grails/cli/fork/ForkedGrailsProcess.groovy
  4. Merge branch '2.3.x' into 2.4.x

    graemerocher committed Jun 13, 2014
    Conflicts:
    	grails-bootstrap/src/main/groovy/org/codehaus/groovy/grails/cli/fork/ForkedGrailsProcess.groovy
  5. Merged changes

    graemerocher committed Jun 13, 2014
  6. Merge branch '2.3.x' into 2.4.x

    lhotari committed Jun 13, 2014
Commits on Jun 12, 2014
  1. improve performance leftShift(Object) method of GrailsPrintWriter

    lhotari committed Jun 12, 2014
    - CompileStatic code picks this method, no call site caching like in dynamic code, so optimize the happy path
  2. optimize GroovyPageOutputStack performance

    lhotari committed Jun 12, 2014
    - reduce unnecessary operations
  3. Merge branch '2.3.x' into 2.4.x

    lhotari committed Jun 12, 2014
  4. upgrade to Aether 1.0.0

    graemerocher committed Jun 12, 2014
  5. Improve the solution that ensures the correct version of spring, groo…

    graemerocher committed Jun 12, 2014
    …vy and grails jars by reading info from GrailsCoreDependencies
  6. fix for GRAILS-11481 "GrailsDispatcherServlet throws IllegalStateExce…

    graemerocher committed Jun 12, 2014
    …ption when using forward() and render()"
    
     Change relates to removal of sitemesh filter in GRAILS-11357.
    
     The filter was removed but the ContentBufferingResponse was not being removed from the request. This causes GrailsOpenSessionInViewInterceptor to not close and unbind the session. This change ensures that the wrapped response is removed from the webRequest and thus the session unbound.
Commits on Jun 11, 2014
  1. GRAILS-11129 - improve class path handling

    jeffbrown committed Jun 10, 2014
    Now if additional classpath is provided with something like this...
    
        grails -classpath /path/to/some/jar run-app
    
    That additional classpath will be used when forking a process.