Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

GRAILS-3468: Add DISABLED and READONLY attributes to the form tags #159

Merged
merged 6 commits into from Feb 23, 2012

Conversation

Projects
None yet
2 participants
Contributor

denisfalqueto commented Jan 27, 2012

These patches implement the fix for that issue. It's very simple and straight forward.

denisfalqueto added some commits Jan 26, 2012

@denisfalqueto denisfalqueto GRAILS-3468: Add DISABLED and READONLY attributes to the form tags
Some form tags already deal correctly with disabled attribute. This
patch spreads that behavior for other tags. It also implements
the same behavior for readonly.
1809b05
@denisfalqueto denisfalqueto GRAILS-3468: Attribute value can be equal to its name
If the attribute value is equal to its name, it will be accepted as
true and will be output.
d7ceb5a
@denisfalqueto denisfalqueto GRAILS-3468: Make the check for attribute value case insensitive 8ad53fa
Owner

graemerocher commented Jan 27, 2012

Could you provide some tests with this pull request?

Contributor

denisfalqueto commented Jan 27, 2012

Sure! :)

denisfalqueto added some commits Jan 27, 2012

@denisfalqueto denisfalqueto GRAILS-3468: Pass through boolean attributes
For compatibility reasons, pass through the provided attribute
value, if it is not a bool or can't be evaluated as such.
A
1e3ad93
@denisfalqueto denisfalqueto GRAILS-3468: Better pass-through for non null values
String values not equal to 'false' or 'true' (case insensitive) or null will be passed
changes to the output. This will enhance compatibility with existing code.
e020b50
@denisfalqueto denisfalqueto GRAILS-3468: test cases bea0f38
Contributor

denisfalqueto commented Jan 30, 2012

I've made a test case that will focus mainly in the function booleanToAttribute, that does the real work. So, not all the tags were explicitly tested, just textField. The other tags will use booleanToAttribute in the same way as textField.

@graemerocher graemerocher added a commit that referenced this pull request Feb 23, 2012

@graemerocher graemerocher Merge pull request #159 from denisfalqueto/master
GRAILS-3468: Add DISABLED and READONLY attributes to the form tags
9970371

@graemerocher graemerocher merged commit 9970371 into grails:master Feb 23, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment