added korean translation of i18n messages #280

Merged
merged 3 commits into from Jun 3, 2015

Conversation

Projects
None yet
5 participants
@issess
Contributor

issess commented Nov 6, 2012

added korean translation of i18n messages

@graemerocher

This comment has been minimized.

Show comment
Hide comment
@graemerocher

graemerocher Nov 26, 2012

Member

We need someone with Korean language to verify this pull request

Member

graemerocher commented Nov 26, 2012

We need someone with Korean language to verify this pull request

@lr

This comment has been minimized.

Show comment
Hide comment
@lr

lr Jan 4, 2013

I do not know Korean grammer, but if you just want to check to make sure they are not trying to inject bad language, etc., into the project, you can use Google Translate. Here is the result of the first one:

http://translate.google.com/#auto/en/%5B%7B1%7D%5D%ED%81%B4%EB%9E%98%EC%8A%A4%EC%9D%98%20%EC%86%8D%EC%84%B1%20%5B%7B0%7D%5D%EC%9D%98%20%5B%7B2%7D%5D%EA%B0%92%EC%9D%80%20%ED%8C%A8%ED%84%B4%20%5B%7B3%7D%5D%EA%B3%BC%20%EC%9D%BC%EC%B9%98%ED%95%98%EC%A7%80%20%EC%95%8A%EC%8A%B5%EB%8B%88%EB%8B%A4.

lr commented Jan 4, 2013

I do not know Korean grammer, but if you just want to check to make sure they are not trying to inject bad language, etc., into the project, you can use Google Translate. Here is the result of the first one:

http://translate.google.com/#auto/en/%5B%7B1%7D%5D%ED%81%B4%EB%9E%98%EC%8A%A4%EC%9D%98%20%EC%86%8D%EC%84%B1%20%5B%7B0%7D%5D%EC%9D%98%20%5B%7B2%7D%5D%EA%B0%92%EC%9D%80%20%ED%8C%A8%ED%84%B4%20%5B%7B3%7D%5D%EA%B3%BC%20%EC%9D%BC%EC%B9%98%ED%95%98%EC%A7%80%20%EC%95%8A%EC%8A%B5%EB%8B%88%EB%8B%A4.

@jeffbrown

This comment has been minimized.

Show comment
Hide comment
@jeffbrown

jeffbrown Jan 4, 2013

Member

I would rather have a native speaker review the text to make sure not only that it translates literally to what makes sense to me (an English speaker) but also things are worded in a way that won't seem goofy to folks who know the language.

Member

jeffbrown commented Jan 4, 2013

I would rather have a native speaker review the text to make sure not only that it translates literally to what makes sense to me (an English speaker) but also things are worded in a way that won't seem goofy to folks who know the language.

@issess

This comment has been minimized.

Show comment
Hide comment
@issess

issess Jan 6, 2013

Contributor

I am korean. I review this translate more 5 times.

Contributor

issess commented Jan 6, 2013

I am korean. I review this translate more 5 times.

@jeffbrown

This comment has been minimized.

Show comment
Hide comment
@jeffbrown

jeffbrown Jan 6, 2013

Member

@issess Thanks. We appreciate the help. I am sure this won't be an issue and we will get it in before the next release. I would like another person to look at it though. Don't take offense. We review each other's stuff all of the time but none of us can review this one, which is why I put a request out to the community. Believe it or not, we sometimes have discussions among ourselves about what messages should be even when they are in English.

It won't be a problem getting this in. Thanks for taking time to put this together.

Member

jeffbrown commented Jan 6, 2013

@issess Thanks. We appreciate the help. I am sure this won't be an issue and we will get it in before the next release. I would like another person to look at it though. Don't take offense. We review each other's stuff all of the time but none of us can review this one, which is why I put a request out to the community. Believe it or not, we sometimes have discussions among ourselves about what messages should be even when they are in English.

It won't be a problem getting this in. Thanks for taking time to put this together.

@stokito

This comment has been minimized.

Show comment
Hide comment
@stokito

stokito Nov 14, 2014

Any movements on this?

stokito commented Nov 14, 2014

Any movements on this?

jeffbrown added a commit that referenced this pull request Jun 3, 2015

Merge pull request #280 from issess/i18n-korean
added korean translation of i18n messages

@jeffbrown jeffbrown merged commit aa0d27e into grails:master Jun 3, 2015

@jeffbrown jeffbrown added this to the grails-3.1 milestone Jun 3, 2015

jeffbrown added a commit that referenced this pull request Jun 4, 2015

Revert "Merge pull request #280 from issess/i18n-korean"
This should be in the profile repository.

This reverts commit aa0d27e, reversing
changes made to 00acbbc.

@issess issess deleted the issess:i18n-korean branch Dec 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment