Skip to content

added korean translation of i18n messages #280

merged 3 commits into from Jun 3, 2015

5 participants

issess commented Nov 6, 2012

added korean translation of i18n messages

grails member

We need someone with Korean language to verify this pull request

lr commented Jan 4, 2013

I do not know Korean grammer, but if you just want to check to make sure they are not trying to inject bad language, etc., into the project, you can use Google Translate. Here is the result of the first one:

grails member

I would rather have a native speaker review the text to make sure not only that it translates literally to what makes sense to me (an English speaker) but also things are worded in a way that won't seem goofy to folks who know the language.

issess commented Jan 6, 2013

I am korean. I review this translate more 5 times.

grails member

@issess Thanks. We appreciate the help. I am sure this won't be an issue and we will get it in before the next release. I would like another person to look at it though. Don't take offense. We review each other's stuff all of the time but none of us can review this one, which is why I put a request out to the community. Believe it or not, we sometimes have discussions among ourselves about what messages should be even when they are in English.

It won't be a problem getting this in. Thanks for taking time to put this together.

stokito commented Nov 14, 2014

Any movements on this?

@jeffbrown jeffbrown merged commit aa0d27e into grails:master Jun 3, 2015
@jeffbrown jeffbrown added this to the grails-3.1 milestone Jun 3, 2015
@jeffbrown jeffbrown added a commit that referenced this pull request Jun 4, 2015
@jeffbrown jeffbrown Revert "Merge pull request #280 from issess/i18n-korean"
This should be in the profile repository.

This reverts commit aa0d27e, reversing
changes made to 00acbbc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.