Upgraded JUnit Version #292

Merged
merged 1 commit into from Dec 11, 2012

Projects

None yet

4 participants

@bobbywarner
grails member

No description provided.

@lhotari
grails member

In some projects I've had problem in having 2 different junit versions on the classpath. Those problems have been fixed by including also junit:junit-dep as a dependency besides junit:junit . In 4.11 junit:junit-dep relocates to junit:junit . Could you check if there is a proper solution to this problem (2 different versions of junit on the classpath). I think spock has a dependency to junit-dep .

@bobbywarner
grails member

@lhotari Sure, I'll look into it.

@graemerocher graemerocher merged commit aa59c20 into grails:master Dec 11, 2012
@jeffbrown
grails member

I think this commit caused a couple of the JavascriptTagLibTests to start failing. They were passing by accident before. This may help: 3b648bb

@lhotari
grails member

Bobby, junit version in master is 4.10 . Could you take a look at upgrading it? Please add a dependency to junit:junit-dep to prevent 2 versions of junit on the classpath. In 4.11 junit:junit-dep relocates to junit:junit . I think spock has a dependency to junit-dep and therefore this is a common problem.

@bobbywarner bobbywarner referenced this pull request Mar 26, 2013
Closed

Updated Junit to 4.11 #340

@bobbywarner
grails member

@lhotari Looks like Spock actually removed the dependency to junit-dep (spockframework/spock@fb46cfc). So, I just updated junit to 4.11 and ran the test suite and everything passed. Submitted as pull request #340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment