GRAILS-9271 - Parameter to specify download location for grails wrapper script #386

Closed
wants to merge 3 commits into
from

Projects

None yet

3 participants

@ctoestreich

Attempt to address allowing user to specify wrapper.cache.dir in grails-wrapper.properties to override default user home location if needed.

@jeffbrown jeffbrown was assigned Aug 23, 2013
@jeffbrown
grails member

I think this code throws an exception of wrapper.cache.dir is not defined and I think the default values for cacheDir and distUrl are reversed. Is all of that correct?

@ctoestreich

Looks like all of that statement is true. I can split out the call to the new method to take three params and check if the wrapper is null before calling getstring or do a null check ternary inline. Also the constants did get switched ( bad copy paste :) )

I can fix and resubmit, let me know.

@jeffbrown
grails member

If you can work up a rev tonight I will look at it tomorrow. Tomorrow is the last day to get changes in for RC2 which is likely the last RC before GA. Thanks.

@ctoestreich

Code changes per @jeffbrown

@lhotari
grails member

@ctoestreich Please open a new pull request that targets 2.4.x branch since master branch is now for Grails 3 development. Please also rebase your commits over the current head of 2.4.x branch.

@lhotari lhotari closed this Aug 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment