Skip to content

GRAILS-10753 Console Colors in Windows - optional fix #433

Closed
wants to merge 1 commit into from

5 participants

@tombujok
tombujok commented Dec 7, 2013

Outputs the ANSI reset sequence and flushes the stream before the System.exit() invocations to make sure that the console has been reset to its default state.
The potential problem could occur when the out stream has not been fully flushed and the System.exit() invocation finished.
Last characters of the out stream contain the ANSI reset sequence - if they are not flushed the console keeps the formatting of the previous message.

@tombujok tombujok GRAILS-10753 Console Colors in Windows - optional fix
Outputs the ANSI reset sequence and flushes the stream before the System.exit() invocations to make sure that the console has been reset to its default state.
199b38f
@lhotari lhotari closed this Apr 14, 2014
@lhotari lhotari reopened this Apr 15, 2014
@lhotari
grails member
lhotari commented Aug 8, 2014

Thanks for the pull request. Could you rebase the commit on the current head of 2.3.x branch?

@ikakara
ikakara commented Jun 16, 2015

FYI - this also happens in grails 3.0.2 and 2.5.0 ... I would be nice to have this fix in both 2.5x and 3x branches.

Thanks!

@ikakara
ikakara commented Jun 16, 2015

@tombujok - do you have time to rebase this?

@lhotari - if the fix is based for 2.5.0, will you add it to the 3.x branch? if tombujok, doesn't have time I can take a crack at rebasing his fix.

@graemerocher graemerocher added this to the grails-3.0.3 milestone Jun 16, 2015
@ikakara
ikakara commented Jun 18, 2015

@lhotari - I went ahead and took @tombujok changes and applied them into the 2.5.x branch: #9025 - I would love for these changes to go into the 2.5.1 release. Let me know if I should merge them into the 3.x branch as well.

Allen

@graemerocher
grails member

#9026 was Merged into 2.5.x branch

@tombujok

Sorry, I did not have time to look into it again - thanks for merging!

@ikakara
ikakara commented Jun 18, 2015

Sure! I didn't merge this into the 3.x branch - does the 2.5 branch automagically get merged into the 3.x branch?

@jeffbrown
grails member

@ikakara The commit at 944636f is on the 2.5.x, 3.0.x and master branch.

@ikakara
ikakara commented Jun 18, 2015

@jeffbrown - thanks for clarifying. I need to figure out how github merging/etc works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.