Edited grails-core/src/main/groovy/org/codehaus/groovy/grails/compiler/GrailsProjectCompiler.groovy via GitHub
…r/GrailsProjectCompiler.groovy via GitHub
This is a very specific fix - shouldn't it only include *.jar and *.zip instead?
Agree it is very specific, but I decided on a known exclusion to fix the issue rather than second guessing whether any plugins would be pulling in other resources (e.g. .properties) from the commonClasspath.
I agree with Burt on the basis that non-JAR dependencies should go into src/java or grails-app/conf. I'm not even sure about including zip files. 'lib' is really for JARs.
The zip file is a legacy from the olden days of Java (e.g. Oracle JDBC 2.0 driver & support classes used to be distributed as classes111.zip).
I'm happy with Burt's suggestion - but hadn't wanted to propose a breaking change (maybe save that for Grails 2.0?).
It is perfectly valid to have any files in the java source tree - code loads this relative to the class using classLoader.getResource without / in the resource path. Example - weceem loads ZIPs this way. Other code can load properties files this way etc. I've seen this in plenty of Java projects over the years...
It's now Grails 2.0 :) So I suggest we go with including *.jar and *.zip. We should make a note in the breaking changes, but I seriously can't imagine anyone being affected adversely by this.
Closing outdated pull requests.