Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Exclude .txt files from plugin lib/ when setting commonClasspath #73

Closed
wants to merge 1 commit into from

5 participants

@rbramley

Edited grails-core/src/main/groovy/org/codehaus/groovy/grails/compiler/GrailsProjectCompiler.groovy via GitHub

See http://grails.1312388.n4.nabble.com/Re-Code-Coverage-running-tests-leads-to-huge-stacktrace-tp3418003p3491065.html

@burtbeckwith
Collaborator

This is a very specific fix - shouldn't it only include *.jar and *.zip instead?

@rbramley

Hi Burt,

Agree it is very specific, but I decided on a known exclusion to fix the issue rather than second guessing whether any plugins would be pulling in other resources (e.g. .properties) from the commonClasspath.

Cheers,

Robin

@pledbrook
Collaborator

I agree with Burt on the basis that non-JAR dependencies should go into src/java or grails-app/conf. I'm not even sure about including zip files. 'lib' is really for JARs.

@rbramley

The zip file is a legacy from the olden days of Java (e.g. Oracle JDBC 2.0 driver & support classes used to be distributed as classes111.zip).

I'm happy with Burt's suggestion - but hadn't wanted to propose a breaking change (maybe save that for Grails 2.0?).

@marcpalmer

It is perfectly valid to have any files in the java source tree - code loads this relative to the class using classLoader.getResource without / in the resource path. Example - weceem loads ZIPs this way. Other code can load properties files this way etc. I've seen this in plenty of Java projects over the years...

@pledbrook
Collaborator

It's now Grails 2.0 :) So I suggest we go with including *.jar and *.zip. We should make a note in the breaking changes, but I seriously can't imagine anyone being affected adversely by this.

@lhotari
Collaborator

Closing outdated pull requests.

@lhotari lhotari closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jun 20, 2011
  1. @rbramley

    Edited grails-core/src/main/groovy/org/codehaus/groovy/grails/compile…

    rbramley authored
    …r/GrailsProjectCompiler.groovy via GitHub
This page is out of date. Refresh to see the latest.
View
2  grails-core/src/main/groovy/org/codehaus/groovy/grails/compiler/GrailsProjectCompiler.groovy
@@ -374,7 +374,7 @@ class GrailsProjectCompiler {
def pluginLibDirs = pluginSettings.pluginLibDirectories.findAll { it.exists() }
for (pluginLib in pluginLibDirs) {
- fileset(dir: pluginLib.file.absolutePath)
+ fileset(dir: pluginLib.file.absolutePath, excludes:'**/*.txt')
}
}
Something went wrong with that request. Please try again.