Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExecuteUpdatePersistentMethod throws NPE when named parameter is null #852

Closed
snimavat opened this issue Jan 2, 2017 · 2 comments
Closed

Comments

@snimavat
Copy link

snimavat commented Jan 2, 2017

ExecuteUpdatePersistentMethod:93 would throw null pointer exception when a named parameter passed to Domain.executeUpdate() is null. However if the parameter is positional parameter, it would work.

Shouldnt it check, if parameter value is null and if so, just set it on query without doing any further checks ?

java.lang.NullPointerException
	at org.codehaus.groovy.grails.orm.hibernate.metaclass.ExecuteUpdatePersistentMethod$1.doInHibernate(ExecuteUpdatePersistentMethod.java:93)
	at org.codehaus.groovy.grails.orm.hibernate.GrailsHibernateTemplate.doExecute(GrailsHibernateTemplate.java:188)
	at org.codehaus.groovy.grails.orm.hibernate.GrailsHibernateTemplate.execute(GrailsHibernateTemplate.java:132)
	at org.codehaus.groovy.grails.orm.hibernate.metaclass.ExecuteUpdatePersistentMethod.doInvokeInternal(ExecuteUpdatePersistentMethod.java:70)
	at org.codehaus.groovy.grails.orm.hibernate.metaclass.AbstractStaticPersistentMethod.invoke(AbstractStaticPersistentMethod.java:79)
	at org.codehaus.groovy.grails.orm.hibernate.metaclass.AbstractStaticPersistentMethod.invoke(AbstractStaticPersistentMethod.java:72)
	at org.codehaus.groovy.grails.orm.hibernate.HibernateGormStaticApi.executeUpdate(HibernateGormStaticApi.groovy:574)
@graemerocher
Copy link
Member

You must be using an old version of GORM, since ExecuteUpdatePersistentMethod no longer exists. Please upgrade.

@snimavat
Copy link
Author

snimavat commented Jan 2, 2017

Oh yes, grails 2.5.5 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants