Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second Bug with effect #85

Closed
Pack-Blepper opened this issue Jan 28, 2024 · 3 comments
Closed

Second Bug with effect #85

Pack-Blepper opened this issue Jan 28, 2024 · 3 comments
Labels

Comments

@Pack-Blepper
Copy link

Pack-Blepper commented Jan 28, 2024

From this example:

declare options "[midi:on][nvoices:12]";
import("stdfaust.lib");
freq = hslider("freq",200,50,1000,0.01);
gain = hslider("gain",0.5,0,1,0.01);
gate = button("gate");
envelope = en.adsr(0.01,0.01,0.8,0.1,gate)*gain;
process = os.sawtooth(freq)*envelope <: _,_;
effect = dm.zita_light;

adding a comment on any line after effect causes the compiler to ignore the definition (here, making the sawtooth sound dry).

declare options "[midi:on][nvoices:12]";
import("stdfaust.lib");
freq = hslider("freq",200,50,1000,0.01);
gain = hslider("gain",0.5,0,1,0.01);
gate = button("gate");
envelope = en.adsr(0.01,0.01,0.8,0.1,gate)*gain;
process = os.sawtooth(freq)*envelope <: _,_;
//foo
effect = dm.zita_light;

runs normally.

declare options "[midi:on][nvoices:12]";
import("stdfaust.lib");
freq = hslider("freq",200,50,1000,0.01);
gain = hslider("gain",0.5,0,1,0.01);
gate = button("gate");
envelope = en.adsr(0.01,0.01,0.8,0.1,gate)*gain;
process = os.sawtooth(freq)*envelope <: _,_;
effect = dm.zita_light;
//foo

makes effect disappear.

@sletz sletz added the bug label Jan 28, 2024
@sletz
Copy link
Member

sletz commented Jan 28, 2024

@Fr0stbyteR stage bug since the same code works correctly in faustwasm standalone mode. Any idea ?

@Fr0stbyteR
Copy link
Contributor

Hmm.. if you put a new line after //foo, the effect appears

@sletz
Copy link
Member

sletz commented Feb 7, 2024

Fixed in 7f18b17 and deployed.

@sletz sletz closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants