Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross Staff Grace Notes rendering issue with Beaming #173

Closed
arshiacont opened this issue Jul 24, 2023 · 3 comments
Closed

Cross Staff Grace Notes rendering issue with Beaming #173

arshiacont opened this issue Jul 24, 2023 · 3 comments

Comments

@arshiacont
Copy link

arshiacont commented Jul 24, 2023

Two issues with the following excerpt:

  1. the crossed staff grace beaming is incorrect
  2. this excerpt will lead to a crash on the Destructor of GRGrace class if the corresponding instance of GRHandler is freed.
{[ \staff<1>  \barFormat<style= "system", range="1-2"> 
   (* meas. 1 *)  \clef<"g2"> \key<-1> \meter<"C/"> 
   \stemsUp f#1/2  a1/4 \stemsDown  d#2/4 \bar<measNum=2> 
   (* meas. 2 *)  f#2/2. _/4 
 ]
 , 
[ \staff<2> 
   (* meas. 1 *)  \clef<"f4"> \key<-1> \meter<"C/"> \stemsUp \grace( \beamBegin:1  b#-2/16 d#-1/16 f#-1/16 a-1/16  b#-1/16 d#0/16 f#0/16
 \beamEnd:1 \staff<1> \stemsDown \beamBegin:1 a0/16 b#0/16 d#1/16 
 \beamEnd:1)
 empty/1 \staff<2>  
   (* meas. 2 *)  \fermata( _/1)
]}

Currently rendered as
image

Expected similar to:
image

@dfober
Copy link
Member

dfober commented Aug 2, 2023

the crash bug is solved, but not yet the beaming issue

@arshiacont
Copy link
Author

Thanks @dfober ! That's already much better

dfober added a commit that referenced this issue Oct 3, 2023
@dfober
Copy link
Member

dfober commented Oct 3, 2023

fixed

@dfober dfober closed this as completed Oct 3, 2023
arshiacont added a commit to Antescofo/guidolib that referenced this issue Oct 18, 2023
…o-develop

* commit 'd1e9bfe9b231656ff6c1296878a4b090e2ab8036':
  fix issue grame-cncm#173
  check pointer
  add QMAKE variable (with default qmake)
  remove docker from workflow
  update to latest
  support for line break in text elements
  update gmn
  change log update
  change version to 2.9 and adapt to Qt 6
  disable dark mode and change version to 2.9
  fix incorrect color dialog behavior at closing
  fix warnings
  fix octava staff crash bug (issue grame-cncm#174)
  new issues
arshiacont added a commit to Antescofo/guidolib that referenced this issue Oct 18, 2023
* antescofo-develop: (339 commits)
  fix issue grame-cncm#173
  check pointer
  add QMAKE variable (with default qmake)
  remove docker from workflow
  update to latest
  support for line break in text elements
  update gmn
  change log update
  change version to 2.9 and adapt to Qt 6
  disable dark mode and change version to 2.9
  fix incorrect color dialog behavior at closing
  fix warnings
  fix octava staff crash bug (issue grame-cncm#174)
  new issues
  skip associations for GRGrace
  fix singlenote contain method after merge
  set font alignment (may result in incorrect placement of dots)
  remove obsolete and non-maintained examples
  add resetCurrentNotesTP + accidentals collisions (in progress)
  fix crash bug due to the new checkHiddenNotes method : change the shared vector management
  ...

# Conflicts:
#	build/CMakeLists.txt
#	src/engine/abstract/ARMusicalVoice.cpp
#	src/engine/abstract/ARNote.cpp
#	src/engine/graphic/GRNotationElement.cpp
#	src/engine/graphic/GRText.cpp
#	src/engine/include/GUIDOScoreMap.h
#	tools/Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants