-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indonesian Translation Tracking #369
Comments
@CikiMomogi so cool to see you're attempting to translate the website to Indonesian! This is a huge effort that should not be underestimated. I hope you are familiar with the translation guide :) We are going to follow your progress closely so we can be sure that the translations are of high quality. Could you tell us the names of all contributors known so far who are going to help you translate this page to Indonesian? A rough estimate is that the translation will take 250-400 work hours, so even if you spent 50 hours per week, it will take more than one month. This is based on how much time the last teams needed. Having someone to review and reiterate is very important because clear language should always be validated by another person to be truly understandable. |
Thanks for the kind words. I've read translation guide and understand that this is a long time-consuming project, should be fully completed, and has potential to be abandoned. I will do my best to complete this project. For the translation quality, I have some experience translating various applications (you can check my crowdin For now I do not have a list of other contributors. Of course, I look forward to readers who are fluent in Indonesian to contribute as well. |
Hi there @CikiMomogi! We want to keep the current quality of our documentation, we want our upcoming translations in other languages to be simple, clear, and easily understandable by the speakers of the respective language. To ensure and enforce a high-quality translation, we need each page to be reviewed individually after it has been translated. Here are some suggestions for your translation process:
Feel free to ask me questions or to tell me if a point needs more clarification. Thank you for your efforts! |
After I merged #375 into my main branch, I got an error when running
|
You need to run This will make sure that |
The error was resolved after I ran |
Regarding point 1 of the following page,
I understand that we can use |
The train of thought is: Need to use So the solution is to use That's simplified, but you get the idea. |
After I read some source code examples, now I completely understood. Previously, I had confused |
@sensen: However, commonly used phrases will remain: I'm pretty sure the readers have learned programming before, therefore they should be familiar with these words. Moreover, the words when translated sound a little weird - at least for me. I want to hear your thoughts on whether this is a good idea. Here is the sample: https://github.com/CikiMomogi/website/pull/20 |
Hey @CikiMomogi! I agree. It sounds weird to me, too. Possibly because we're very familiar with the English words. I can't remember the last timeI read documentation in Indonesian language. But if I were to do that, I'd prefer the documentation to keep the technical terms in English. If you decided to go with this, I'd suggest not translating even |
Can I change the link reference from Deno website/site/docs/guide/deployment-types.md Line 152 in 0565e6b
to here? website/site/docs/guide/deployment-types.md Line 235 in 0565e6b
Since the content is the same, I think it would be better to redirect readers to the translated doc instead. |
There are two links in the line of text you reference, and one of them already refers to website/site/docs/guide/deployment-types.md Line 235 in 0565e6b
|
The second one. https://doc.deno.land/https://deno.land/x/grammy/mod.ts/~/ApiClientOptions#canUseWebhookReply |
Yes, so you want to have identical two links in the same sentence? |
Well, I can rearrange the words to reference the single link. But, I wonder if you did them intentionally, except for avoiding the two identical link in the same sentence. |
The API reference is always more comprehensive and more accurate than the website because it is directly generated from the code, but the website is more high-level and easier to understand. In cases where it really matters, such as here where messages could potentially get lost, it is often good advice to check out the API reference in addition. That's why I would like to keep both links. However, I do see the point that the content behind the two links is redundant now. This happened because the docs used not to go into depth here, which was a bit of a pitfall, so we decided to make the drawbacks more prominent. I have opened #418 which fixes the problem. Can you check it out and say if that phrasing is better? |
Yep, looks good to me! |
Is const { Bot } = require("grammy");
const bot = new Bot("<token>");
// Stopping the bot when Node process
// is about to be terminated
process.once("SIGINT", () => bot.stop());
process.once("SIGTERM", () => bot.stop());
await bot.start(); Deno: import { Bot } from "https://deno.land/x/grammy@v1.8.3/mod.ts";
const bot = new Bot("<token>");
// Stopping the bot when Node process
// is about to be terminated
Deno.addSignalListener("SIGINT", () => bot.stop());
Deno.addSignalListener("SIGTERM", () => bot.stop());
await bot.start(); Also, I don't understand the meaning of both registered and trademark symbols in the last paragraph |
Thank you for the report, @CikiMomogi! I've opened #421 related to that, can you please do me a review? |
Don't we need to import website/site/docs/advanced/transformers.md Lines 93 to 113 in 2d7ba3b
|
No, |
Can somebody please check my PQ? The github actions keep failing. However, when I ran |
This is because of the recent Deno 1.23.0 update. Look how denoland/deno#14841 was merged and now affects existing files in all future CI runs. Feel free to fix it, even though that means you'll touch unrelated files. @roj1512 it would be great if you could push a formatting commit upstream. |
Oh, so that's the reason. I guess it's perfect time to upgrade my Deno. |
@KnorpelSenf I don't have access to his fork. |
You mean you do not have write access? |
ye |
I guess that's the disadvantage of doing translations in forks. Do you need write access for anything, i.e. is there anything you can't do via forking? Should I ask @CikiMomogi to give you write access? 😄 |
Of course I can make a PR to reformat. I thought you mean I just push to his upstream |
Ah I see, sorry, I meant the main repo, but now I fixed it myself in #422 |
I should've maybe referred back to #369 (comment) from #422 🤔 |
Glad it's fixed anyway |
I'm a bit lost as to what Moreover, why even bother storing the payload if we can simply fetch the name of the message sender directly from website/site/docs/plugins/menu.md Lines 313 to 331 in f223baf
|
Creator refers to the original author of the message, also across forwards. While we could clarify that, it's also a very primitive example to illustrate the feature without much code. Maybe we can find a real-world use case that is better suited as an example to explain this. Do you have any suggestions? |
Page not found at the following link: website/site/docs/plugins/auto-retry.md Line 75 in 748e38d
Is it supposed to reference this link, https://raw.githubusercontent.com/grammyjs/auto-retry/main/src/index.ts? |
https://doc.deno.land/https://raw.githubusercontent.com/grammyjs/auto-retry/main/src/index.ts is the correct link. Deno changed something in the way they represent their URLs, which broke this link. It used to work before. |
Got it! I will make the PQ. |
@KnorpelSenf @roj1512 Do you guys need a review approval for each pull request in my repository? Currently I have approval request enabled only for one collaborator. |
@CikiMomogi nope, it's fine! |
website/site/docs/resources/comparison.md Lines 41 to 43 in f1bc534
What is |
Types give information about the code to the editor. That's why providing types improves how well your editor can support you. Types equals editor support. |
Is the editor here referring to the code editor? Therefore, by providing types, it can bring more information to the code editor and thus improve productivity and make it easier for users. |
Yes, the TypeScript types improve what VSCode can do for you. We describe this in more depth a few paragraphs later. |
https://github.com/orgs/CikiMomogi-grammY/teams/translator/discussions/3/comments/8
"Does the CSS intentionally use |
Yes, all styles are here:
Feel free to play around with the config. For example, it looks like your browser isn't able to hyphenate Indonesian. This issue does not appear in English. |
SELESAI..!!! 🥳 Terima kasih yang sebanyak-banyaknya untuk @fadzikri dan @sensen atas masukan, saran dan bantuan perbaikan terjemahannya selama 3 bulan lebih ini. Not to mention @KnorpelSenf and @roj1512 for their guidance and patience to answer my noob questions 😅. |
🇮🇩 Indonesian
Deskripsi
Issue ini digunakan untuk memantau proses translasi semua halaman. Issue akan ditutup ketika semua dokumentasi berhasil diselesaikan.
Ikutan dong...!!!
Menjadi Penerjemah
Menjadi Penyunting
Silahkan dikoreksi PR translasi yang sudah dibuat. Tambahkan catatan jika diperlukan.
Catatan
Kata-kata yang berhubungan dengan methods, nama function, variables... tidak perlu diterjemahkan. Berikut beberapa contohnya:
🇬🇧 English
Description
This issue is for tracking the translation progress of all pages and will be closed when the documentation is finished.
I want to collaborate too!
Being a translator
Being a reviewer
Find the PR's created for translations and review them. Add all notes that you consider.
Note
Words related to methods, function names, variables... mustn't be translated. Here are some examples:
📝 Translation progress
README
Advanced
Demo
Guide
Hosting
Plugins
Resources
Config
The text was updated successfully, but these errors were encountered: