Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to hide ages for events after death #1399

Merged
merged 1 commit into from Jul 1, 2023

Conversation

Nick-Hall
Copy link
Member

This PR adds the option to hide the age in the person editor for events after death.

Read the Calculating age for burials topic for further details.

@DaveSch-gramps
Copy link
Contributor

Installed the PR and works great.

I am wondering if the default should be "True" which is the current scenario and expected by users.

@emyoulation
Copy link
Contributor

Please identify the label text of the option for those of use who have not installed. Is the 'True' for a "Hide" option or its inverse, a "Show" option.

Either way, a "show" should be the default. Otherwise newbies may never find it.

@Nick-Hall
Copy link
Member Author

The option is "Display ages for events after death". I'll change the default to True so that it matches the current behaviour.

@emyoulation
Copy link
Contributor

emyoulation commented Oct 26, 2022

The other 2 options (in the "display" Preferences tab) are labeled "Show", not "Display"

Maybe the code starts with "Display" but the GUI label is consistent in the rest in the tab with "Show"?

@DaveSch-gramps
Copy link
Contributor

The other 2 options (in the "display" Preferences tab) are labeled "Show", not "Display"

Maybe the code starts with "Display" but the GUI label is consistent in the rest in the tab with "Show"?

The display age after death option will not become available until 5.2 and will display on the Data tab of a totally reworked configure.py file.

@cdhorn
Copy link
Contributor

cdhorn commented Mar 7, 2023

This one worked fine for me too.

@Nick-Hall Nick-Hall merged commit 21c7952 into gramps-project:master Jul 1, 2023
1 check passed
@Nick-Hall Nick-Hall deleted the age-after-death branch July 1, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants