A couple of minor edits #12

Merged
merged 3 commits into from Feb 28, 2013

Conversation

Projects
None yet
2 participants
Contributor

rorz commented Feb 26, 2013

The code (.m) wouldn't compile without fixing:

  • A typo in one of the ARC macros
  • A requirement for compiling: that one of the accessibility objects was bridged.

rorz added some commits Feb 25, 2013

@rorz rorz Update Lockbox.m
Typo fix (__bridge in macro)
b5df134
@rorz rorz ARC Support Update
added __bridge prefix to accessibility item for better ARC compiling.
dde690e
Owner

granoff commented Feb 26, 2013

Oops! Thanks. Change the explicit "__bridge id" you added to LOCKBOX_ID and I'll accept the change.

Contributor

rorz commented Feb 26, 2013

Sorry about the second Pull Request - it's the first time I've amended code on GitHub. I'm not quite sure about the code you want me to change: to remove the second change (accessibility object) or something else?

Owner

granoff commented Feb 26, 2013

No problem. Where you changed accessibility to (__bridge id)(accessibility), the macro LOCKBOX_ID should be used instead of __bridge id. So it should be (LOCKBOX_ID)accessibility.

@rorz rorz Change Explicit Definition
Amended (__bridge) to implicit (LOCKBOX_ID) macro.
cfc0a62
Contributor

rorz commented Feb 26, 2013

Ah I see, of course! Thanks for pointing that out, and sorry for my naivety in using the Pull Request system! Thanks very much for an awesome class!

@granoff granoff added a commit that referenced this pull request Feb 28, 2013

@granoff granoff Merge pull request #12 from rorz/master
A couple of minor edits
22bfc9f

@granoff granoff merged commit 22bfc9f into granoff:master Feb 28, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment