Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when this npm module user installs

Merged
merged 1 commit into from Mar 13, 2019
Merged

Fix error when this npm module user installs #7

merged 1 commit into from Mar 13, 2019

Conversation

lulzneko
Copy link
Contributor

@lulzneko lulzneko commented Mar 13, 2019

An error occurs when installing validate-typescript.
This pull request is a fix that avoids the error.

username@PC:~/project$ npm install validate-typescript

> validate-typescript@4.0.0 install ~/project/node_modules/validate-typescript
> cd test && npm install

sh: 1: cd: can't cd to test
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! validate-typescript@4.0.0 install: `cd test && npm install`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the validate-typescript@4.0.0 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     ~/.npm/_logs/2019-03-13T25_67_89_000Z-debug.log

This error is because I've run npm install validate-typescript, which chained calls to the downloaded validate-typescript package's install.
(And the downloaded validate-typescript package does not have a test directory)

Empty the validate-typescript install script to avoid errors.
And I created a setup script that does the same thing as the current install script does.
Please run npm run setup when developing validate-typescript.
This is equivalent to the current npm install.

The same process as the current install script is moved to the setup name.
It contains npm install, so it can do the same thing as the current install script.
When developing validate-typescript, npm run setup can do the same as npm install.

Thank you for the great product.

@grant-zietsman grant-zietsman merged commit 2b64d5f into grant-zietsman:develop Mar 13, 2019
@grant-zietsman
Copy link
Owner

grant-zietsman commented Mar 13, 2019

Thanks, you should be able to run npm install validate-typescript without an error now. (v4.0.1)

@lulzneko lulzneko deleted the develop branch Mar 14, 2019
@lulzneko
Copy link
Contributor Author

lulzneko commented Mar 14, 2019

Thank you for the quick merge and release !
Our project was also installed correctly 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants