New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use eval for resolving URLs. If a CSS File uses base64 encoded images in data tags, HTTP::CDN dies. #1

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@mradile

mradile commented Jan 26, 2015

HTTP::CDN fails.

@grantm

This comment has been minimized.

Show comment
Hide comment
@grantm

grantm Sep 11, 2016

Owner

Hi Martin. I seem to have completely forgotten about this pull request you logged against Dancer::Plugin::CDN a year and a half ago. I apologise for the neglect.

I seem to recall thinking at the time you raised this request that the right thing to do was to fix the underlying problem in HTTP::CDN rather than add an eval here that would potentially hide the problem. Martyn Smith has merged a couple of commits from me into that module and I see he also has one from you that seems related to this PR.

If you have no objection, my inclination is to abandon this PR. But if you have an example of a problem that this fixes, I'd be happy to take a look.

Regards
Grant

Owner

grantm commented Sep 11, 2016

Hi Martin. I seem to have completely forgotten about this pull request you logged against Dancer::Plugin::CDN a year and a half ago. I apologise for the neglect.

I seem to recall thinking at the time you raised this request that the right thing to do was to fix the underlying problem in HTTP::CDN rather than add an eval here that would potentially hide the problem. Martyn Smith has merged a couple of commits from me into that module and I see he also has one from you that seems related to this PR.

If you have no objection, my inclination is to abandon this PR. But if you have an example of a problem that this fixes, I'd be happy to take a look.

Regards
Grant

@mradile

This comment has been minimized.

Show comment
Hide comment
@mradile

mradile Sep 11, 2016

Hi Grant,

i have created a pull request for HTTP::CDN resolving this issue and is was accepted.
I am sorry that i did not remove this pull request or left a note about that here.

As the issue is already solved, please remove this pull request.

Regards

Martin

PS: the PR is martynsmith/HTTP-CDN#5

mradile commented Sep 11, 2016

Hi Grant,

i have created a pull request for HTTP::CDN resolving this issue and is was accepted.
I am sorry that i did not remove this pull request or left a note about that here.

As the issue is already solved, please remove this pull request.

Regards

Martin

PS: the PR is martynsmith/HTTP-CDN#5

@mradile mradile closed this Sep 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment