Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
use eval for resolving URLs. If a CSS File uses base64 encoded images in data tags, HTTP::CDN dies. #1
Hi Martin. I seem to have completely forgotten about this pull request you logged against Dancer::Plugin::CDN a year and a half ago. I apologise for the neglect.
I seem to recall thinking at the time you raised this request that the right thing to do was to fix the underlying problem in HTTP::CDN rather than add an eval here that would potentially hide the problem. Martyn Smith has merged a couple of commits from me into that module and I see he also has one from you that seems related to this PR.
If you have no objection, my inclination is to abandon this PR. But if you have an example of a problem that this fixes, I'd be happy to take a look.
i have created a pull request for HTTP::CDN resolving this issue and is was accepted.
As the issue is already solved, please remove this pull request.
PS: the PR is martynsmith/HTTP-CDN#5