Browse files

core install_to_host() method no longer dies on an install failure

 - fix propagation of return value
  • Loading branch information...
1 parent 9961bf8 commit 85b4a4c053acafb35b86368dd56a39118d35df02 @grantm committed Oct 6, 2012
Showing with 10 additions and 3 deletions.
  1. +4 −0 plugins/InstallManager/Changes
  2. +6 −3 plugins/InstallManager/lib/App/BCVI/InstallManager.pm
View
4 plugins/InstallManager/Changes
@@ -1,5 +1,9 @@
Revision history for App-BCVI-InstallManager
+1.02 2012-10-06
+ - the core install_to_host() method no longer dies on an install
+ failure - fix propagation of return value
+
1.01 2010-06-05
- add sub option to list installed hosts
- add sub option to remove host from list
View
9 plugins/InstallManager/lib/App/BCVI/InstallManager.pm
@@ -7,7 +7,7 @@ use Digest::MD5;
use Fcntl;
use SDBM_File;
-our $VERSION = '1.01';
+our $VERSION = '1.02';
my($source_signature, %sig_db, $db_file);
@@ -72,8 +72,11 @@ sub install_to_host {
my($self, $host) = @_;
my $sig = $self->install_source_signature();
- $self->SUPER::install_to_host($host);
- $self->set_install_signature($host=> $sig);
+ if( $self->SUPER::install_to_host($host) ) {
+ $self->set_install_signature($host=> $sig);
+ return 1;
+ }
+ return;
}

0 comments on commit 85b4a4c

Please sign in to comment.