docs: document the playwright e2e workflow#2630
Merged
Merged
Conversation
The existing single-line mention ("E2E tests use Playwright: yarn
playwright") doesn't say where the tests live, how to install the
browsers, how to point them at a non-default port/backend, or that
they require a running storefront. Expand it so new contributors can
actually run the suite (and so it's clear that adding new tests means
dropping a `<feature>.playwright.ts` next to the package).
Also documents the `URL` and `PLAYWRIGHT_LOCALES` env vars used by
`playwright.config.ts` after the ESM-loader fix in #2627.
🦋 Changeset detectedLatest commit: 21df051 The changes in this PR will be included in the next version bump. This PR includes changesets to release 86 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Picks up the loose ends from #2627 which fixed
playwright.config.tssonpx playwright testactually loads. The existing CLAUDE.md only mentioned Playwright in a single sentence (`E2E tests use Playwright: `yarn playwright``) — it didn't say:packages/<pkg>/test/<feature>.playwright.ts, picked up viatestMatch: ['**/*.playwright.ts'])npx playwright install chromium)URLenv var for non-default ports / backendsPLAYWRIGHT_LOCALES=nl,deopt-in env var added in feat(next-ui): add YoutubeEmbed component #2627test-results/andplaywright-report/are gitignored local artifactsExpand the Testing section so a new contributor can actually run the suite, and so it's clear that adding new tests means dropping a
<feature>.playwright.tsnext to the package.Test plan
🤖 Generated with Claude Code