Skip to content

test(next-config): regenerate mergeEnvIntoConfig snapshot to unblock CI#2632

Merged
paales merged 1 commit into
canaryfrom
ci/fix-config-snapshot
May 20, 2026
Merged

test(next-config): regenerate mergeEnvIntoConfig snapshot to unblock CI#2632
paales merged 1 commit into
canaryfrom
ci/fix-config-snapshot

Conversation

@paales
Copy link
Copy Markdown
Member

@paales paales commented May 20, 2026

Summary

Every PR's pr-analysis / test job has been failing on canary with a snapshot mismatch in mergeEnvIntoConfig — unrelated to the PR's own changes. Example: latest run on #2628 https://github.com/graphcommerce-org/graphcommerce/actions/runs/26162186314/job/76978986351 ends with:

Snapshot \`parses an env config object 1\` mismatched

- Expected
+ Received

+   "GC_DEMO_MODE": true,
    "GC_STOREFRONT": [ … hygraphLocales: ["en"] … ],
    "GC_STOREFRONT_0_DEFAULT_LOCALE": true,
+   "GC_STOREFRONT_0_HYGRAPH_LOCALES_0": "en",
    "GC_STOREFRONT_0_LOCALE": "en",
    "GC_STOREFRONT_0_MAGENTO_STORE_CODE": "en_us",
+   "GC_STOREFRONT_1_HYGRAPH_LOCALES_0": "de",
    "GC_STOREFRONT_1_LOCALE": "de",
    "GC_STOREFRONT_1_MAGENTO_STORE_CODE": "de_de",
  }

 ❯ packagesDev/next-config/__tests__/config/utils/mergeEnvIntoConfig.ts:48:18

Root cause: the test input at mergeEnvIntoConfig.ts:21-34 was updated to include GC_DEMO_MODE, GC_STOREFRONT_0_HYGRAPH_LOCALES_0, and GC_STOREFRONT_1_HYGRAPH_LOCALES_0 when those fields landed in the config schema, but the committed snapshot was never regenerated. The env-schema parser correctly emits those three extra keys; the snapshot just doesn't expect them.

This PR only updates the snapshot to match the schema. No code change, no behaviour change, no other tests touched. Once merged, every other PR's test job goes green without rebasing.

Test plan

  • Snapshot diff matches the runtime output exactly as reported by the CI failure.
  • pr-analysis / test passes on this PR.

🤖 Generated with Claude Code

The `parses an env config object` test feeds the env-schema parser
`GC_DEMO_MODE='1'`, `GC_STOREFRONT_0_HYGRAPH_LOCALES_0='en'`, and
`GC_STOREFRONT_1_HYGRAPH_LOCALES_0='de'`, but the committed snapshot
still reflects the pre-`demoMode` / pre-flattened-`hygraphLocales`
schema. Every CI run since those config fields were added (and the
test input updated) has failed the `test` job on every PR with a
snapshot mismatch unrelated to the PR's own changes:

  Snapshot \`parses an env config object 1\` mismatched
  + "GC_DEMO_MODE": true,
  + "GC_STOREFRONT_0_HYGRAPH_LOCALES_0": "en",
  + "GC_STOREFRONT_1_HYGRAPH_LOCALES_0": "de",

Update the snapshot to match the schema. No code change.
@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
graphcommerce-246 Ready Ready Preview May 20, 2026 2:25pm
graphcommerce-247 Ready Ready Preview May 20, 2026 2:25pm
graphcommerce-hygraph-dynamic-rows-ui Ready Ready Preview May 20, 2026 2:25pm
graphcommerce-open-source Ready Ready Preview May 20, 2026 2:25pm
graphcommerce-storyblok Ready Ready Preview May 20, 2026 2:25pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 20, 2026

🦋 Changeset detected

Latest commit: c25106b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 86 packages
Name Type
@graphcommerce/next-config Patch
@graphcommerce/hygraph-dynamic-rows-ui Patch
@graphcommerce/framer-scroller-example Patch
@graphcommerce/magento-graphcms Patch
@graphcommerce/magento-open-source Patch
@graphcommerce/magento-storyblok Patch
@graphcommerce/docs Patch
@graphcommerce/browserslist-config-pwa Patch
@graphcommerce/changeset-changelog Patch
@graphcommerce/eslint-config-pwa Patch
@graphcommerce/graphql-codegen-markdown-docs Patch
@graphcommerce/graphql-codegen-near-operation-file Patch
@graphcommerce/graphql-codegen-relay-optimizer-plugin Patch
@graphcommerce/misc Patch
@graphcommerce/prettier-config-pwa Patch
@graphcommerce/typescript-config-pwa Patch
@graphcommerce/address-fields-nl Patch
@graphcommerce/algolia-categories Patch
@graphcommerce/algolia-insights Patch
@graphcommerce/algolia-personalization Patch
@graphcommerce/algolia-products Patch
@graphcommerce/algolia-recommend Patch
@graphcommerce/algolia-search Patch
@graphcommerce/cli Patch
@graphcommerce/demo-magento-graphcommerce Patch
@graphcommerce/ecommerce-ui Patch
@graphcommerce/framer-next-pages Patch
@graphcommerce/framer-scroller Patch
@graphcommerce/framer-utils Patch
@graphcommerce/google-datalayer Patch
@graphcommerce/google-playstore Patch
@graphcommerce/googleanalytics Patch
@graphcommerce/googlerecaptcha Patch
@graphcommerce/googletagmanager Patch
@graphcommerce/graphcms-ui Patch
@graphcommerce/graphql-mesh Patch
@graphcommerce/graphql Patch
@graphcommerce/hygraph-cli Patch
@graphcommerce/hygraph-dynamic-rows Patch
@graphcommerce/hygraph-ui Patch
@graphcommerce/image Patch
@graphcommerce/lingui-next Patch
@graphcommerce/magento-cart-checkout Patch
@graphcommerce/magento-cart-coupon Patch
@graphcommerce/magento-cart-email Patch
@graphcommerce/magento-cart-items Patch
@graphcommerce/magento-cart-payment-method Patch
@graphcommerce/magento-cart-pickup Patch
@graphcommerce/magento-cart-shipping-address Patch
@graphcommerce/magento-cart-shipping-method Patch
@graphcommerce/magento-cart Patch
@graphcommerce/magento-category Patch
@graphcommerce/magento-cms Patch
@graphcommerce/magento-compare Patch
@graphcommerce/magento-customer Patch
@graphcommerce/magento-graphql-rest Patch
@graphcommerce/magento-graphql Patch
@graphcommerce/magento-newsletter Patch
@graphcommerce/magento-payment-adyen Patch
@graphcommerce/magento-payment-afterpay Patch
@graphcommerce/magento-payment-braintree Patch
@graphcommerce/magento-payment-included Patch
@graphcommerce/magento-payment-klarna Patch
@graphcommerce/magento-payment-multisafepay Patch
@graphcommerce/magento-payment-paypal Patch
@graphcommerce/magento-payment-tokens Patch
@graphcommerce/magento-product-bundle Patch
@graphcommerce/magento-product-configurable Patch
@graphcommerce/magento-product-downloadable Patch
@graphcommerce/magento-product-grouped Patch
@graphcommerce/magento-product-simple Patch
@graphcommerce/magento-product-virtual Patch
@graphcommerce/magento-product Patch
@graphcommerce/magento-recently-viewed-products Patch
@graphcommerce/magento-review Patch
@graphcommerce/magento-search-overlay Patch
@graphcommerce/magento-search Patch
@graphcommerce/magento-store Patch
@graphcommerce/magento-wishlist Patch
@graphcommerce/mollie-magento-payment Patch
@graphcommerce/next-ui Patch
@graphcommerce/react-hook-form Patch
@graphcommerce/service-worker Patch
@graphcommerce/storyblok-ui Patch
@graphcommerce/framer-next-pages-example Patch
@graphcommerce/image-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant