fix(next-ui): scope MuiFabSizes width/height to circular Fabs#2633
Merged
Conversation
Default Fab size is `large` (54px). Without filtering on variant, every `<Fab variant="extended">` without an explicit size matched the `large` rule and got `width: 54px, height: 54px` applied, collapsing extended Fabs to a fixed square regardless of their label. Scope the size variants to `variant: 'circular'` so extended Fabs grow with their label (consumers control the floor via `min-width`).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 7554ad4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 86 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MuiFabSizesinpackages/next-ui/Theme/MuiFab.tsapplieswidth+heightfor every supported Fabsize, but does not filter onvariant. The default Fab size islarge(54px), so every<Fab variant="extended">rendered without an explicitsizematches thelargevariant rule and getswidth: 54px, height: 54px— collapsing extended Fabs to a fixed square regardless of their label. Consumer-sideminWidthoverrides lose the specificity battle against MUI's variant rules.This scopes the size variants to
variant: 'circular'so that:width: auto+ amin-widthfloor controlled by the consumer).Test plan
<Fab variant="extended">Customize</Fab>withoutsizenow renders pill-shaped, not a square.<Fab size="responsive">(circular, default variant) keeps its responsive width/height.