From ee02bc1122e445827617cd6a459305ae78195a23 Mon Sep 17 00:00:00 2001 From: easbar Date: Thu, 10 Oct 2019 17:31:29 +0200 Subject: [PATCH] Make measurement not output numbers as strings --- .../java/com/graphhopper/tools/Measurement.java | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/tools/src/main/java/com/graphhopper/tools/Measurement.java b/tools/src/main/java/com/graphhopper/tools/Measurement.java index 0ec130dd31a..c63e5cd0537 100644 --- a/tools/src/main/java/com/graphhopper/tools/Measurement.java +++ b/tools/src/main/java/com/graphhopper/tools/Measurement.java @@ -56,7 +56,7 @@ */ public class Measurement { private static final Logger logger = LoggerFactory.getLogger(Measurement.class); - private final Map properties = new TreeMap<>(); + private final Map properties = new TreeMap<>(); private long seed; private int maxNode; @@ -578,13 +578,12 @@ void print(String prefix, MiniPerfTest perf) { } void put(String key, Object val) { - // convert object to string to make serialization possible - properties.put(key, "" + val); + properties.put(key, val); } private void storeJson(String graphLocation, String jsonLocation) { logger.info("storing measurement json in " + jsonLocation); - String gitInfo = properties.get("gh.gitinfo"); + String gitInfo = properties.get("gh.gitinfo").toString(); if (gitInfo == null) { logger.error("gitinfo not available, writing properties instead of json"); storeProperties(graphLocation, jsonLocation); @@ -615,10 +614,10 @@ private void storeProperties(String graphLocation, String propLocation) { try (FileWriter fileWriter = new FileWriter(propLocation)) { String comment = "measurement finish, " + new Date().toString() + ", " + Constants.BUILD_DATE; fileWriter.append("#" + comment + "\n"); - for (Entry e : properties.entrySet()) { + for (Entry e : properties.entrySet()) { fileWriter.append(e.getKey()); fileWriter.append("="); - fileWriter.append(e.getValue()); + fileWriter.append(e.getValue().toString()); fileWriter.append("\n"); } fileWriter.flush(); @@ -693,10 +692,8 @@ private String getSummaryLogLine(String[] properties, String propLocation) { } private String getFormattedProperty(String property) { - String result = properties.get(property); - if (result == null) { - result = "missing"; - } + Object resultObj = properties.get(property); + String result = resultObj == null ? "missing" : resultObj.toString(); // limit number of decimal places for floating point numbers try { double doubleValue = Double.parseDouble(result.trim());