Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing through a fence. #1468

Closed
AllroadsNL opened this issue Sep 28, 2018 · 10 comments
Closed

Routing through a fence. #1468

AllroadsNL opened this issue Sep 28, 2018 · 10 comments
Labels
Milestone

Comments

@AllroadsNL
Copy link

AllroadsNL commented Sep 28, 2018

Routing problem, situation

Situation
Forum discussion, dutch, with extra images

This could be tagged several ways.
The simple one: a way barrier=fence and a way highway=* have a shared node.
You can not route through a fence.
But others, set on this node barrier=fence, should not be needed.
Or other tags to help a router.

More simple, when two ways are crossing ( not a shared node), same layer= (or not mentioned), a router should understand that he can not router through a fence. I think this should also not router, basic rule.

Only with a other barrier, like barrier=gate, shared node. With a access, if needed, it can router through.

@karussell
Copy link
Member

karussell commented Sep 28, 2018

This is more a data problem that we discussed here: https://forum.openstreetmap.org/viewtopic.php?id=58238

Recently we switch from default "blocking" to default "passing" (FlagEncoder.setBlockByDefault) like it is implied in the editor iD if you add a barrier. See e.g. #754. So if access=no is added this should be fixed.

What we can do from our side is in this case we could add barrier=fence to the absolute barriers of all vehicle profiles.

@karussell karussell added the osm label Sep 28, 2018
@karussell karussell added this to the 0.12 milestone Sep 28, 2018
@AllroadsNL
Copy link
Author

to the absolute barriers of all vehicle profiles.

also foot.

For me it is not a data problem, it is a problem how we interpret the data, we have to analyze barrier, wall and fence (these kinds) we can never go through, others, there is a possibility to continue, with a delay or not or it is closed periodically. (conditional)

A default for all barriers is not working.
The reality is that it is odd to set a extra access=no on a fence.

Throw the default rule over the wall, nobody can access it easy.

@karussell
Copy link
Member

The reality is that it is odd to set a extra access=no on a fence.

For the fence I have now written a patch that will fix the behaviour, but for many other barriers the default behaviour it is not clear at all.

karussell added a commit that referenced this issue Sep 28, 2018
@Marc-marc-marc
Copy link

@karussell
Copy link
Member

karussell commented Oct 8, 2018

is the patch already released ?

Not yet, will be fixed in the next week.

@karussell
Copy link
Member

This already works now, right?

@Marc-marc-marc
Copy link

for my usecase, somebody delete the gate https://www.openstreetmap.org/node/4142767062 and disconnect both way https://www.openstreetmap.org/way/412956261 to bypass routing issue.
so no idea if it works with 2 connected ways with a gate

@karussell
Copy link
Member

Uhm, ugly. I recommend to revert this to the real world and we make the routing working :)

@AllroadsNL
Copy link
Author

In the opening example one of the roads is set to access=private. Graphhopper taking a road nearby
So not on both sides without access or yes.
Maybe make a overpass to search for a new situation.

@zhiqiangZHAO
Copy link
Contributor

here is another barrier=fence https://www.openstreetmap.org/node/5666329763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants