New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bicycle/MTB routing should observe bicycle=yes on a barrier #407
Comments
|
I fully support the propsual. It makes sense, especially for vehicle type mountainbike. After having read the definition for a kissing_gate barrier in the wiki I would even allow it for the mounainbike vehicle case also without the "bicycle=yes" tag combination. I would implement this in one step, this probably shouldn't be too difficult. |
|
I prepared a patch at ratrun@731422e |
|
Thanks, looks good! Would you create a PR from this commit? |
Fix for #407 "Bicycle/MTB routing should observe bicycle=yes on a barrier
|
I think the current implementation is too limiting. If there's a tag bicycle=yes on a kissing_gate barrier, it should allow all bike types, not only mountain bikes. Here's an overpass query which shows 34 such barriers in Munich - I seriously doubt one needs an MTB there ;-) |
|
(reopened this issue due to this and the discussion on the mailing) |
|
Could you please provide a picture of a kissing_gate which can be passed easily by bike and where you put would set the tag Here is the "reference" picture from the OSM wiki: http://wiki.openstreetmap.org/w/images/thumb/7/7b/TL0452_stile.jpg/300px-TL0452_stile.jpg I doubt that the 34 kissing_gates in Munich are tagged correctly. I don't want to be routed via such an obstacle except on a mountainbike tour. Currently graphhopper cannot put a big penalty cost on it as far as I know and therefor I would like to block them. You need to get off the bike, at least open a gate and close it again. Most kissing_gates I'm aware of require you to lift the bike to 90 degrees and wheel it on the rear wheel around a very tight 180 degree cage thing. Those things are a real pain in the ass. I doubt that as a cyclist you would lough as these two ladies do: See http://tinyurl.com/og9zh8z . |
lol |
|
@ratrun I'll get you some pictures... "You need to get off the bike, at least open a gate and close it again." right - and somebody during tagging explicitly said that bikes are allowed. So would you rather get rerouted some hundred meters or more around that "obstacle"? personally, even on my race bike, I'd rather briefly jump off the bike and probably stay on a smaller track as a result... So, IMHO, if someone has explicitly put a tag bicycle=yes on any barrier, there's no rational of blocking this barrier completely during bicycle routing. Even more so since GH hardcodes that (compare to Routino which puts these kind of decisions into a user modifiable XML file). Penalty, fine, but no resulting reroute. Just my 5 cents... |
|
Hmmh, really hard decision. Probably for racing bike we should allowed it too. But for normal bike we should not allow it, as for them we have to assume luggage which makes this a real hassle. Of course in a later version we make this configurable (#193) |
|
In the Netherlands aka 'the bicycle country', I found this restriction being too restrictive. I plan cycling trips every week on our national cycling node network. Basically the purple lines on OpenCycleMap. These routes and cycleways are acessible and meant for all types of bicycles. I was a bit shocked to see our beloved GraphHopper routing arround many of the very nice spots these routes take you along. Because of the kissing gate, you cannot reach the old fort. This is only one of the many examples where graphhopper doesn't route over our national cycling network :( Kind regards, |
|
Yeah. Especially if it is explicitly tagged we should indeed allow it and move those barriers with And of course also the current work on customizable routing should be expanded to node tags too. |
|
When I did the research for the kissing_gate 6 years ago I only used https://wiki.openstreetmap.org/wiki/Tag:barrier%3Dkissing_gate as input. From the description there about the small space in the cage I came to the conclustion that such a thing is not designed for bicycles and therefore the I still believe that these are tagging errors in most cases. @PatrickvEk Do you have a picture of a kissing_gate which you can easily pass with a touring bike loaded with panniers without putting it on the rear wheel? On Wikipedia https://en.wikipedia.org/wiki/Kissing_gate they are talking about an additional conventional gate nearby or a latch : Regarding the |
Yes of course, this a kissing gate i'm using often with the regular bike. You can run it arround in the big round cage without lifting the rear wheel (and luggage). The Diameter of the cage is quite big, meant for regular bikes. Picture of the situation from the link above: Kind Regards, |
… see discussion in graphhopper#407.
|
The picture and taginfo https://taginfo.openstreetmap.org/tags/barrier=kissing_gate#combinations convinced me. |
|
Thank you very much. Good to know about the tag-info helper. Thanks for that as well ;) |
…ks for all bicycles except for mountainbike or when tagged together with bicycle=yes.
…ate blocks for all bicycles except for mountainbike or when tagged together with bicycle=yes." This reverts commit bba2e67. Revert "Allow barrier kissing_gate with bicycle=yes for all bicycle profiles, see discussion in graphhopper#407." This reverts commit e5db3b5.
… as result of discussion in graphhopper#407.
#2340) * Allow barrier kissing_gate with bicycle=yes for all bicycle profiles, see discussion in #407. * Improve implementation for #407: barrier kissing_gate blocks for all bicycles except for mountainbike or when tagged together with bicycle=yes. * Revert "Improve implementation for #407: barrier kissing_gate blocks for all bicycles except for mountainbike or when tagged together with bicycle=yes." This reverts commit bba2e67. Revert "Allow barrier kissing_gate with bicycle=yes for all bicycle profiles, see discussion in #407." This reverts commit e5db3b5. * Improve barrier handling for "stile", "turn_stile" and "kissing_gate" as result of discussion in #407.
|
This ticket can be closed. |
Presently, a node with a tag barrier=kissing_gate and bicycle=yes blocks bicycle or mtb routing through that node.
IMHO, a tag bicycle=yes should override any barrier on a node (same goes for stile, turnstile, etc). Plus, the bicycle=yes tag should allow routing for all "bike-types".
The text was updated successfully, but these errors were encountered: