Create separate source module for import and core #450

Closed
karussell opened this Issue Jun 21, 2015 · 4 comments

Projects

None yet

2 participants

@karussell
Member
karussell commented Jun 21, 2015 edited

The whole OSM reading stuff should be in a separate source module 'import-osm' which needs a bit refactoring so that we can finally do

hopper = new GraphHopperOSM().setOSMFile(...)
hopper.importOrLoad()

and on Android etc we should be able to avoid setting OSM related stuff and just do:

hopper = new GraphHopper();
hopper.load(ghFolder)

We should use the change to separate OSM better from the core. Furthermore we could easier integrate other readers like #277 and #616.

@karussell karussell referenced this issue in graphhopper/graphhopper-ios Jun 21, 2015
Open

Pod file #7

@karussell karussell changed the title from Create separate source for import and core module to avoid hacks for iOS and Android to Create separate source module for import and core to avoid hacks for iOS and Android Jun 21, 2015
@devemux86
Contributor

You mean like split into modules for graph creation, perform routing etc. (like the current tools) ?

@karussell
Member

Yes. Just moving the import code out of core, so that Android and iOS does not need to exclude those xml reading stuff. Or if Android at some point implements its, it can just add it as dependency

@devemux86
Contributor
devemux86 commented Jun 22, 2015 edited

👍
In mobile platforms the import (aka creation) of graphs is a bit difficult due to device restrictions.

@karussell karussell changed the title from Create separate source module for import and core to avoid hacks for iOS and Android to Create separate source module for import and core Jun 11, 2016
@karussell karussell added this to the 0.8 milestone Jun 12, 2016
@karussell karussell added a commit that referenced this issue Jun 12, 2016
@karussell karussell initial commit to separate core from osm reader, fixes #450 4053c89
@karussell karussell added a commit that closed this issue Jul 15, 2016
@karussell karussell separate module for OSM import, fixes #450 12a5cbf
@karussell karussell closed this in 12a5cbf Jul 15, 2016
@devemux86
Contributor

@karussell nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment