Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Includes default u-turn cost in time calculation, fixes #1585. #1635

Merged
merged 8 commits into from Jun 12, 2019

Conversation

@easbar
Copy link
Collaborator

easbar commented Jun 11, 2019

This PR fixes the last remaining issue in #1585. The time calculation did not include the default u-turn cost (used when TraversalMode.EDGE_BASED_2DIR_UTURN is enabled).

With this in place I think we are ready to finally clean up the u-turn traversal mode etc. in #1520 :)

easbar added 7 commits Jun 11, 2019
Copy link
Member

karussell left a comment

Thanks, looks good :)

@@ -110,6 +116,10 @@ public double calcTurnWeight(int edgeFrom, int nodeVia, int edgeTo) {
return turnCostEncoder.getTurnCost(turnFlags);
}

public double getDefaultTurnCost() {
return defaultUTurnCost;

This comment has been minimized.

Copy link
@karussell

karussell Jun 12, 2019

Member

Should we indicate the unit in the docs like we do for the setter? (Also do you think we should refactor the unit to milliseconds at a later point for consistency with the calcMillis method?)

This comment has been minimized.

Copy link
@easbar

easbar Jun 12, 2019

Author Collaborator

Ok I added javadocs. And yes we should try to make the units consistent.

@karussell karussell added the bug label Jun 12, 2019
@karussell karussell added this to the 0.13 milestone Jun 12, 2019
@easbar easbar merged commit 05a7fb1 into master Jun 12, 2019
5 checks passed
5 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - pom.xml (karussell) No new issues
Details
security/snyk - web/package.json (karussell) No manifest changes detected
@easbar easbar referenced this pull request Jun 12, 2019
4 of 4 tasks complete
@karussell karussell deleted the default_uturn_times branch Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.