Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve speed of elevation interpolation #1649

Merged
merged 1 commit into from Jun 27, 2019

Conversation

@karussell
Copy link
Member

karussell commented Jun 27, 2019

…set implementation, fixes #1648
@karussell karussell force-pushed the issue_1648 branch from 5cc93e6 to 19401c4 Jun 27, 2019
@karussell karussell added the bug label Jun 27, 2019
@karussell karussell added this to the 0.13 milestone Jun 27, 2019
@karussell karussell merged commit 653b108 into master Jun 27, 2019
2 of 5 checks passed
2 of 5 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
security/snyk - pom.xml (karussell) No new issues
Details
security/snyk - web/package.json (karussell) No manifest changes detected
@karussell karussell deleted the issue_1648 branch Jun 27, 2019
* Pick the BitSet implementation wisely. Use GHBitSetImpl only if we are sure you visit a large portion of the graph.
* And if you choose GHTBitSet the initial capacity can be also important for performance.
*/
protected abstract GHBitSet createBitSet();

This comment has been minimized.

Copy link
@easbar

easbar Jun 27, 2019

Collaborator

Ah this again :) Good idea to make this abstract so one has to pick the bit set explicitly.

return new GHBitSetImpl();
}
/**
* Pick the BitSet implementation wisely. Use GHBitSetImpl only if we are sure you visit a large portion of the graph.

This comment has been minimized.

Copy link
@easbar

easbar Jun 27, 2019

Collaborator

Maybe use {@link GHBitSetImpl} for easier code navigation and refactoring ?

karussell added a commit that referenced this pull request Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.