Increase maximum number of base graph edges for edge-based CH#3010
Merged
Increase maximum number of base graph edges for edge-based CH#3010
Conversation
easbar
commented
May 16, 2024
Comment on lines
+829
to
+830
| toNodesAndFwdFlags.add(getIntWithFlag(to, fwd)); | ||
| keysAndBwdFlags.add(getIntWithFlag(GHUtility.createEdgeKey(edge, false), bwd)); |
Member
Author
There was a problem hiding this comment.
Storing one access flag with the nodes and one with the edges has no disadvantage memory-wise, because we do not use the 32nd bit anyway (we use only positive nodes and edge keys).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far we weren't able to run the edge-based CH preparation for graphs with more than 536mio edges. With this PR the limit is 1037mio. This is because we are storing edge keys in the preparation graph (twice as many as there are edges) and we are not using the negative range for the edge keys yet.