Conversation
ratrun
approved these changes
Jun 21, 2024
Contributor
ratrun
left a comment
ratrun
left a comment
There was a problem hiding this comment.
The implementation code looks indeed much cleaner now!
core/src/test/java/com/graphhopper/routing/util/parsers/BikeTagParserTest.java
Show resolved
Hide resolved
Contributor
|
I just tested this. Didn't see any improvements (because I think didn't encounter bugs like this) but works as expected 👍 |
ratrun
approved these changes
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the bike speed parsing is too complicated, especially the handling of the "pushing speed". I adapted the code while keeping all unit tests. This made it clear that e.g. the default speed for path and footway was incorrectly set IMO which I fixed.
I stumbled over this unclear code while I wanted to fix this bug (see new test case).
@ratrun @caspg please have a look if this is an improvement for you too.