Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

higher quality images #34

Closed
denjello opened this issue Jul 12, 2015 · 2 comments
Closed

higher quality images #34

denjello opened this issue Jul 12, 2015 · 2 comments

Comments

@denjello
Copy link
Contributor

DDV creates jpeg stills at around 75% quality. These artifact-laden images are then analyzed and iteratively "dreamt", then saved again in the lossy jpg format. While I was battle-testing the shell scripts, I noticed an incredible loss of fidelity in the resulting video.

Of the many other image formats available, I recommend png. This will probably make the entire pipeline slower, but will result in higher quality.

In keeping with the "choose your own toolkit" approach, I could imagine making a PR that allows the user to choose to sacrifice performance for quality by defining the compression [ png | jpg20 | jpg40 | jpg60 | jpg80 ].

Should the user choose png, then the service should probably ALWAYS try to pngcrush the images before continuing.

Shall I go ahead with this?

@graphific
Copy link
Owner

excellent idea: power to the user, let them decide, but png would actually make sense indeed!

@graphific
Copy link
Owner

implemented with warning if pngcrush not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants