New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

megacarbon setup misses maintenance plugins #106

Open
anatolijd opened this Issue May 23, 2013 · 3 comments

Comments

Projects
None yet
3 participants
@anatolijd

anatolijd commented May 23, 2013

I just found that megacarbon's installation does install 'bin/ceres-maintenance' but misses maintenance plugins from 'plugins/maintenance/'.

I think it is correct to install them to $GRAPHITE_ROOT/plugins/maintenance,
so, perhaps, setup.py should be updated, like:

28,29c28
+ ceres_plugins = [('plugins/maintenance',glob('plugins/maintenance/*.py'))]
- install_files = storage_dirs + conf_files
+ install_files = storage_dirs + conf_files + ceres_plugins
@rowanu

This comment has been minimized.

Show comment
Hide comment
@rowanu

rowanu May 28, 2013

Good point.

Can you make this in to a pull request please?

rowanu commented May 28, 2013

Good point.

Can you make this in to a pull request please?

@ralphm

This comment has been minimized.

Show comment
Hide comment
@ralphm

ralphm Jul 16, 2013

With #107 merged into the megacarbon branch, isn't this fixed?

ralphm commented Jul 16, 2013

With #107 merged into the megacarbon branch, isn't this fixed?

@rowanu

This comment has been minimized.

Show comment
Hide comment
@rowanu

rowanu Jul 26, 2013

Yep, @ralphm is right - this issue should be closed.

rowanu commented Jul 26, 2013

Yep, @ralphm is right - this issue should be closed.

cbowman0 pushed a commit to cbowman0/carbon that referenced this issue Nov 5, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment