New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow special characters in target names to be escaped #242

Closed
mleinart opened this Issue Mar 14, 2013 · 2 comments

Comments

Projects
None yet
3 participants
@mleinart
Member

mleinart commented Mar 14, 2013

I think this is primarily a change to the pyparsing grammar for targets (https://github.com/graphite-project/graphite-web/blob/master/webapp/graphite/render/grammar.py).

Though the browse tree code should also know how to deal with a target name like this properly once a fix is in place in the rendering code.
#120 is an option as well, but I feel like url encoding doesnt really belong that far down from the view code. Instead, I think we can solve it by starting to treat the targets more as we would other grammars and just 'backslash it out'

e.g. a metric named

systems.web01.load(5min)

would be added as:

systems.web01.load\(5min\)
@mingbowan

This comment has been minimized.

Contributor

mingbowan commented Mar 31, 2014

what about file system paths? like "/usr/local"? You cannot escape "/" in file path

@felixbarny

This comment has been minimized.

felixbarny commented May 8, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment