Add history and zoom to graph #123

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
3 participants

spellik commented Dec 18, 2012

Allow user view history graphs and zoom graphs. Like cacti

spellik closed this Dec 18, 2012

spellik reopened this Dec 18, 2012

Member

SEJeff commented Jan 28, 2013

Unfortunately, the javascript file you include is GPL licensed and graphite is Apache licensed. This would effectively change the license of graphite to GPL and I don't think that is going to pass muster.

spellik commented Jan 28, 2013

Hello.

History functions don`t need any GPL scripts.

With best regards, Oleg.

2013/1/28 Jeff Schroeder notifications@github.com

Unfortunately, the javascript file you include is GPL licensed and
graphite is Apache licensed. This would effectively change the license of
graphite to GPL and I don't think that is going to pass muster.


Reply to this email directly or view it on GitHubhttps://github.com/graphite-project/graphite-web/pull/123#issuecomment-12786516.

Member

nleskiw commented Jan 28, 2013

Hi,

bonsai.js is a GPLv2 file.

You cannot add it to this project.

Read this for more information:

http://www.apache.org/licenses/GPL-compatibility.html

-Nick
On Jan 28, 2013 9:45 AM, "spellik" notifications@github.com wrote:

Hello.

History functions don`t need any GPL scripts.

With best regards, Oleg.

2013/1/28 Jeff Schroeder notifications@github.com

Unfortunately, the javascript file you include is GPL licensed and
graphite is Apache licensed. This would effectively change the license
of
graphite to GPL and I don't think that is going to pass muster.


Reply to this email directly or view it on GitHub<
https://github.com/graphite-project/graphite-web/pull/123#issuecomment-12786516>.


Reply to this email directly or view it on GitHubhttps://github.com/graphite-project/graphite-web/pull/123#issuecomment-12787762.

spellik commented Jan 29, 2013

Hello

bonsai.js need for zoom. History work without external JS

2013/1/29 Nicholas Leskiw notifications@github.com

Hi,

bonsai.js is a GPLv2 file.

You cannot add it to this project.

Read this for more information:

http://www.apache.org/licenses/GPL-compatibility.html

-Nick
On Jan 28, 2013 9:45 AM, "spellik" notifications@github.com wrote:

Hello.

History functions don`t need any GPL scripts.

With best regards, Oleg.

2013/1/28 Jeff Schroeder notifications@github.com

Unfortunately, the javascript file you include is GPL licensed and
graphite is Apache licensed. This would effectively change the license
of
graphite to GPL and I don't think that is going to pass muster.


Reply to this email directly or view it on GitHub<

https://github.com/graphite-project/graphite-web/pull/123#issuecomment-12786516>.


Reply to this email directly or view it on GitHub<
https://github.com/graphite-project/graphite-web/pull/123#issuecomment-12787762>.


Reply to this email directly or view it on GitHubhttps://github.com/graphite-project/graphite-web/pull/123#issuecomment-12807671.

Member

nleskiw commented Jan 29, 2013

Please remove it, then.

-Nick

On Jan 29, 2013, at 12:33 AM, spellik notifications@github.com wrote:

Hello

bonsai.js need for zoom. History work without external JS

2013/1/29 Nicholas Leskiw notifications@github.com

Hi,

bonsai.js is a GPLv2 file.

You cannot add it to this project.

Read this for more information:

http://www.apache.org/licenses/GPL-compatibility.html

-Nick
On Jan 28, 2013 9:45 AM, "spellik" notifications@github.com wrote:

Hello.

History functions don`t need any GPL scripts.

With best regards, Oleg.

2013/1/28 Jeff Schroeder notifications@github.com

Unfortunately, the javascript file you include is GPL licensed and
graphite is Apache licensed. This would effectively change the license
of
graphite to GPL and I don't think that is going to pass muster.


Reply to this email directly or view it on GitHub<

https://github.com/graphite-project/graphite-web/pull/123#issuecomment-12786516>.


Reply to this email directly or view it on GitHub<
https://github.com/graphite-project/graphite-web/pull/123#issuecomment-12787762>.


Reply to this email directly or view it on GitHubhttps://github.com/graphite-project/graphite-web/pull/123#issuecomment-12807671.


Reply to this email directly or view it on GitHub.

spellik commented Jan 29, 2013

Removed.

@SEJeff SEJeff added a commit to SEJeff/graphite-web that referenced this pull request May 3, 2013

@SEJeff SEJeff Move the history button into Graph Operations in the dash
This is cleaning up fallout from #123
d323ee0

SEJeff closed this May 18, 2013

@cbowman0 cbowman0 added a commit to cbowman0/graphite-web that referenced this pull request Aug 31, 2013

@SEJeff @cbowman0 SEJeff + cbowman0 Move the history button into Graph Operations in the dash
This is cleaning up fallout from #123

Conflicts:

	webapp/content/js/dashboard.js
349ef61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment