When using functions like removeBelowValue, data series might be empty. ... #150

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@bryantsai

When using functions like removeBelowValue, data series might be empty. Legends of such empty series are still shown, which is not so perfect especially when the number of legends are not small. Added check for such condition so such legends are ignored automatically.

@bryantsai bryantsai When using functions like removeBelowValue, data series might be empt…
…y. Legends of such empty series are still shown, which is not so perfect especially when the number of legends are not small. Added check for such condition so such legends are ignored automatically.
ff6e360
@obfuscurity
Graphite Project member

I like the intent, but I think that not showing legend elements because all values are Null is confusing. What happens when someone requests 2 metrics and one of them doesn't render because there are no datapoints? I think this has the potential to be very confusing.

cc @mleinart for his input.

@obfuscurity
Graphite Project member

After discussing with @mleinart I think that the right approach is not to automatically start hiding null series (which would introduce unexpected behavior), but to add a function (e.g. "hideNullFromLegend") that would allow for hiding these sorts of series from the legend.

@bryantsai Would you mind tweaking this as a function like I describe?

Note: I'm not saying that @mleinart agrees with me, only that I discussed this with him.

@obfuscurity
Graphite Project member

Closing in favor of #1618.

@obfuscurity obfuscurity added a commit to obfuscurity/graphite-web that referenced this pull request Aug 18, 2016
@obfuscurity obfuscurity new param to hideNullFromLegend, refs #150 64eda47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment