Skip to content

Fix pull request CI/CD, remove secret from Dockerfile #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 27, 2022
Merged

Fix pull request CI/CD, remove secret from Dockerfile #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
71695cd
test build
promaty Jan 27, 2022
edd8f5a
try cache
promaty Jan 27, 2022
062819a
use npm secret
promaty Jan 27, 2022
48915d6
use NEXT_PUBLIC_BASE_PATH
promaty Jan 27, 2022
a2dc1bc
remove secret from dockerfile
promaty Jan 27, 2022
40415f7
remove test build
promaty Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci-cd-production.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ jobs:
context: . # required to respect .dockerignore
cache-from: type=registry,ref=${{ env.BASE_IMAGE }}:latest
cache-to: type=inline
secrets: npmrc=//registry.npmjs.org/:_authToken=${{ secrets.NPM_SECRET_TOKEN }}
tags: |
${{ env.BASE_IMAGE }}:${{ github.sha }}
${{ env.BASE_IMAGE }}:latest
Expand Down
18 changes: 2 additions & 16 deletions .github/workflows/ci-cd-pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ on: pull_request

env:
BASE_IMAGE: ghcr.io/graphprotocol/graph-docs-staging
HEALTH_CHECK_URL: https://staging.thegraph.com/docs
APP_NAME: graph-docs
NEXT_PUBLIC_BASE_PATH: /docs

jobs:
Expand All @@ -15,22 +13,10 @@ jobs:
- name: Checkout the repo
uses: actions/checkout@v2

- name: Login to GitHub Container Registry
uses: docker/login-action@v1
with:
registry: ghcr.io
username: nenadjaja
password: ${{ secrets.GH_ACCESS_TOKEN }}

- name: Build and push Docker image
- name: Build Docker image
uses: docker/build-push-action@v2
with:
context: . # required to respect .dockerignore
cache-from: type=registry,ref=${{ env.BASE_IMAGE }}:latest
cache-to: type=inline
secrets: npmrc=//registry.npmjs.org/:_authToken=${{ secrets.NPM_SECRET_TOKEN }}
tags: |
${{ env.BASE_IMAGE }}:${{ github.sha }}
${{ env.BASE_IMAGE }}:latest
push: true
push: false
build-args: NEXT_PUBLIC_BASE_PATH=${{ env.NEXT_PUBLIC_BASE_PATH }}
1 change: 0 additions & 1 deletion .github/workflows/ci-cd-staging.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ jobs:
context: . # required to respect .dockerignore
cache-from: type=registry,ref=${{ env.BASE_IMAGE }}:latest
cache-to: type=inline
secrets: npmrc=//registry.npmjs.org/:_authToken=${{ secrets.NPM_SECRET_TOKEN }}
tags: |
${{ env.BASE_IMAGE }}:${{ github.sha }}
${{ env.BASE_IMAGE }}:latest
Expand Down
3 changes: 1 addition & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ COPY ./package.json /app/package.json
COPY ./yarn.lock /app/yarn.lock

# install the packages
RUN --mount=type=secret,id=npmrc,dst=/root/.npmrc \
yarn install
RUN yarn install

# copy the rest
COPY . .
Expand Down