Skip to content

fix: add backoff if could not find heaviest allocation #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 23, 2024
Merged

fix: add backoff if could not find heaviest allocation #397

merged 5 commits into from
Oct 23, 2024

Conversation

@carlosvdr
Copy link
Contributor

@carlosvdr carlosvdr commented Oct 23, 2024

No description provided.

@carlosvdr carlosvdr requested a review from gusinacio October 23, 2024 19:08
@carlosvdr carlosvdr self-assigned this Oct 23, 2024
@coveralls
Copy link

coveralls commented Oct 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11488359772

Details

  • 42 of 43 (97.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 72.665%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tap-agent/src/agent/sender_account.rs 22 23 95.65%
Totals Coverage Status
Change from base Build 11488190522: -0.03%
Covered Lines: 5003
Relevant Lines: 6885
💛 - Coveralls

gusinacio
gusinacio reviewed Oct 23, 2024
View reviewed changes
gusinacio
gusinacio reviewed Oct 23, 2024
View reviewed changes
@gusinacio gusinacio changed the title feat: create a backoff sender level in case no allocation was fix: add backoff if could not find heaviest allocation Oct 23, 2024
gusinacio
gusinacio approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but there's a test failing, could you check it?

@gusinacio gusinacio marked this pull request as ready for review October 23, 2024 20:36
gusinacio
gusinacio suggested changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@gusinacio gusinacio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the logic is wrong, we still want to check for counter even if it doesn't have backoff

@carlosvdr carlosvdr force-pushed the carlosvdr/tap-247-create-a-backoff-sender-level-in-case-no-allocation-was branch from f9cbc0c to ee64ff8 Compare October 23, 2024 21:21
@carlosvdr carlosvdr requested a review from gusinacio October 23, 2024 21:29
gusinacio
gusinacio approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gusinacio gusinacio merged commit f9b64f3 into main Oct 23, 2024
9 of 10 checks passed
@gusinacio gusinacio deleted the carlosvdr/tap-247-create-a-backoff-sender-level-in-case-no-allocation-was branch October 23, 2024 21:56
@github-actions github-actions bot mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gusinacio gusinacio gusinacio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carlosvdr carlosvdr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@carlosvdr @coveralls @gusinacio