Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .NET Core #43

Closed
chmontgomery opened this issue Jan 5, 2016 · 13 comments
Closed

Support .NET Core #43

chmontgomery opened this issue Jan 5, 2016 · 13 comments

Comments

@chmontgomery
Copy link

@chmontgomery chmontgomery commented Jan 5, 2016

Do you have plans to release a version that supports DNXCore,Version=v5.0? Are there any external dependencies blocking this?

@joemcbride
Copy link
Member

@joemcbride joemcbride commented Jan 5, 2016

I would certainly like to support DNX. I haven't tried it yet. The main dependency that could hold things up is the Antlr runtime.

@chmontgomery
Copy link
Author

@chmontgomery chmontgomery commented Jan 5, 2016

it seems like Antlr4 already supports this as of v4.5-alpha003: tunnelvisionlabs/antlr4cs#126

@joemcbride
Copy link
Member

@joemcbride joemcbride commented Jan 6, 2016

👍 Right now my highest priorities are:

  • Failing CI when tests fail due to test runner crashing
  • Adding validation

Going to update this issue title to reflect this request. You're welcome to take a stab at it!

@joemcbride joemcbride changed the title plans to support DNXCore,Version=v5.0? Support DNXCore,Version=v5.0 Jan 6, 2016
@alexsandro-xpt
Copy link

@alexsandro-xpt alexsandro-xpt commented Feb 4, 2016

+1

@we4sz
Copy link

@we4sz we4sz commented Mar 7, 2016

+1

@natemcmaster
Copy link

@natemcmaster natemcmaster commented Mar 19, 2016

Unless the dependency on Antlr4 is removed, this will be hard to complete before Antlr also supports .NET Core. See antlr/antlr4#1142

Also, DNX is being retired. It's better to support its replacement, dotnet cli. See https://github.com/dotnet/cli.

@joemcbride joemcbride changed the title Support DNXCore,Version=v5.0 Support .NET Core Mar 21, 2016
@joemcbride joemcbride mentioned this issue Aug 1, 2016
@baluubas
Copy link

@baluubas baluubas commented Aug 5, 2016

If someone is really itching (like me) to make the move to .NET core then I've made a quick and ditry port based on this fork of antlr4: https://github.com/lecode-official/antlr4

You can find it here:
https://www.myget.org/feed/Packages/baluubas

Needless to say, it comes with a huge disclaimer.

@tlil
Copy link
Contributor

@tlil tlil commented Aug 5, 2016

@baluubas also, have a look at: #127 :)

@baluubas
Copy link

@baluubas baluubas commented Aug 5, 2016

@tlil87 Awesome, looking forward to a .NET core build

@joemcbride
Copy link
Member

@joemcbride joemcbride commented Aug 29, 2016

Have an alpha nuget up on the AppVeyor feed for .NET Core support if anyone wants to give it a whirl.

0.12.0-alpha-510

https://ci.appveyor.com/nuget/graphql-dotnet
https://ci.appveyor.com/project/graphql-dotnet-ci/graphql-dotnet/build/0.12.0.510/artifacts

I've tried it with a .NET 4.6.1 console app and a .NET Core console app.

/cc @tlil87 @baluubas @jquense

@joemcbride
Copy link
Member

@joemcbride joemcbride commented Aug 29, 2016

I went ahead and published 0.12.0-alpha-511 to nuget as well.

@baluubas
Copy link

@baluubas baluubas commented Aug 29, 2016

0.12.0-alpha-511 works perfectly in my core solution, no hiccups so far.

@tlil
Copy link
Contributor

@tlil tlil commented Aug 29, 2016

Works great here as well - will keep testing it and report if I see any issues 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

7 participants
You can’t perform that action at this time.