Support .NET Core #43

Closed
chmontgomery opened this Issue Jan 5, 2016 · 13 comments

Comments

Projects
None yet
7 participants
@chmontgomery

Do you have plans to release a version that supports DNXCore,Version=v5.0? Are there any external dependencies blocking this?

@joemcbride

This comment has been minimized.

Show comment
Hide comment
@joemcbride

joemcbride Jan 5, 2016

Member

I would certainly like to support DNX. I haven't tried it yet. The main dependency that could hold things up is the Antlr runtime.

Member

joemcbride commented Jan 5, 2016

I would certainly like to support DNX. I haven't tried it yet. The main dependency that could hold things up is the Antlr runtime.

@chmontgomery

This comment has been minimized.

Show comment
Hide comment
@chmontgomery

chmontgomery Jan 5, 2016

it seems like Antlr4 already supports this as of v4.5-alpha003: tunnelvisionlabs/antlr4cs#126

it seems like Antlr4 already supports this as of v4.5-alpha003: tunnelvisionlabs/antlr4cs#126

@joemcbride

This comment has been minimized.

Show comment
Hide comment
@joemcbride

joemcbride Jan 6, 2016

Member

👍 Right now my highest priorities are:

  • Failing CI when tests fail due to test runner crashing
  • Adding validation

Going to update this issue title to reflect this request. You're welcome to take a stab at it!

Member

joemcbride commented Jan 6, 2016

👍 Right now my highest priorities are:

  • Failing CI when tests fail due to test runner crashing
  • Adding validation

Going to update this issue title to reflect this request. You're welcome to take a stab at it!

@joemcbride joemcbride changed the title from plans to support DNXCore,Version=v5.0? to Support DNXCore,Version=v5.0 Jan 6, 2016

@alexsandro-xpt

This comment has been minimized.

Show comment
Hide comment
@we4sz

This comment has been minimized.

Show comment
Hide comment

we4sz commented Mar 7, 2016

+1

@natemcmaster

This comment has been minimized.

Show comment
Hide comment
@natemcmaster

natemcmaster Mar 19, 2016

Unless the dependency on Antlr4 is removed, this will be hard to complete before Antlr also supports .NET Core. See antlr/antlr4#1142

Also, DNX is being retired. It's better to support its replacement, dotnet cli. See https://github.com/dotnet/cli.

Unless the dependency on Antlr4 is removed, this will be hard to complete before Antlr also supports .NET Core. See antlr/antlr4#1142

Also, DNX is being retired. It's better to support its replacement, dotnet cli. See https://github.com/dotnet/cli.

@joemcbride joemcbride changed the title from Support DNXCore,Version=v5.0 to Support .NET Core Mar 21, 2016

@koistya koistya referenced this issue in jpsingleton/ANCLAFS Jun 19, 2016

Closed

Add GraphQL for .NET #2

@joemcbride joemcbride referenced this issue Aug 1, 2016

Merged

New Parser #127

@baluubas

This comment has been minimized.

Show comment
Hide comment
@baluubas

baluubas Aug 5, 2016

If someone is really itching (like me) to make the move to .NET core then I've made a quick and ditry port based on this fork of antlr4: https://github.com/lecode-official/antlr4

You can find it here:
https://www.myget.org/feed/Packages/baluubas

Needless to say, it comes with a huge disclaimer.

baluubas commented Aug 5, 2016

If someone is really itching (like me) to make the move to .NET core then I've made a quick and ditry port based on this fork of antlr4: https://github.com/lecode-official/antlr4

You can find it here:
https://www.myget.org/feed/Packages/baluubas

Needless to say, it comes with a huge disclaimer.

@tlil

This comment has been minimized.

Show comment
Hide comment
@tlil

tlil Aug 5, 2016

Contributor

@baluubas also, have a look at: #127 :)

Contributor

tlil commented Aug 5, 2016

@baluubas also, have a look at: #127 :)

@baluubas

This comment has been minimized.

Show comment
Hide comment
@baluubas

baluubas Aug 5, 2016

@tlil87 Awesome, looking forward to a .NET core build

baluubas commented Aug 5, 2016

@tlil87 Awesome, looking forward to a .NET core build

@joemcbride

This comment has been minimized.

Show comment
Hide comment
@joemcbride

joemcbride Aug 29, 2016

Member

Have an alpha nuget up on the AppVeyor feed for .NET Core support if anyone wants to give it a whirl.

0.12.0-alpha-510

https://ci.appveyor.com/nuget/graphql-dotnet
https://ci.appveyor.com/project/graphql-dotnet-ci/graphql-dotnet/build/0.12.0.510/artifacts

I've tried it with a .NET 4.6.1 console app and a .NET Core console app.

/cc @tlil87 @baluubas @jquense

Member

joemcbride commented Aug 29, 2016

Have an alpha nuget up on the AppVeyor feed for .NET Core support if anyone wants to give it a whirl.

0.12.0-alpha-510

https://ci.appveyor.com/nuget/graphql-dotnet
https://ci.appveyor.com/project/graphql-dotnet-ci/graphql-dotnet/build/0.12.0.510/artifacts

I've tried it with a .NET 4.6.1 console app and a .NET Core console app.

/cc @tlil87 @baluubas @jquense

@joemcbride

This comment has been minimized.

Show comment
Hide comment
@joemcbride

joemcbride Aug 29, 2016

Member

I went ahead and published 0.12.0-alpha-511 to nuget as well.

Member

joemcbride commented Aug 29, 2016

I went ahead and published 0.12.0-alpha-511 to nuget as well.

@baluubas

This comment has been minimized.

Show comment
Hide comment
@baluubas

baluubas Aug 29, 2016

0.12.0-alpha-511 works perfectly in my core solution, no hiccups so far.

0.12.0-alpha-511 works perfectly in my core solution, no hiccups so far.

@tlil

This comment has been minimized.

Show comment
Hide comment
@tlil

tlil Aug 29, 2016

Contributor

Works great here as well - will keep testing it and report if I see any issues 👍

Contributor

tlil commented Aug 29, 2016

Works great here as well - will keep testing it and report if I see any issues 👍

@joemcbride joemcbride closed this in #167 Sep 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment