Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Result.AppendErrors #434

Merged
merged 2 commits into from Mar 9, 2019

Conversation

Projects
None yet
4 participants
@fishy
Copy link
Contributor

fishy commented Jan 8, 2019

This is a thread-safe way of appending errors into Result.Errors, as we
are currently doing it in different goroutines.

This fixes #429

Add Result.AppendErrors
This is a thread-safe way of appending errors into Result.Errors, as we
are currently doing it in different goroutines.

This fixes #429
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 8, 2019

Coverage Status

Coverage increased (+0.009%) to 92.246% when pulling 9f66740 on fishy:fix-data-race into d902887 on graphql-go:master.

@songlh

songlh approved these changes Feb 19, 2019

Copy link

songlh left a comment

Looks good to me, and the two races have successfully been removed.

@songlh

This comment has been minimized.

Copy link

songlh commented Feb 19, 2019

Should we merge this pull request?

@chris-ramon

This comment has been minimized.

Copy link
Member

chris-ramon commented Mar 9, 2019

LGTM 👍 🚢 — Thanks a lot for your contribution @fishy, and for your review @songlh!

@chris-ramon chris-ramon merged commit bf68c1b into graphql-go:master Mar 9, 2019

6 checks passed

ci/circleci: coveralls Your tests passed on CircleCI!
Details
ci/circleci: golang:1.11 Your tests passed on CircleCI!
Details
ci/circleci: golang:1.8.7 Your tests passed on CircleCI!
Details
ci/circleci: golang:1.9.7 Your tests passed on CircleCI!
Details
ci/circleci: golang:latest Your tests passed on CircleCI!
Details
coverage/coveralls Coverage increased (+0.009%) to 92.246%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.