Jackson mapper default property inclusion should be "ALWAYS" to prevent null values from being omitted in query results #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S' because GraphQL should always include all requested properties by default (fixes graphql-java-kickstart#135)
bsara
changed the title
bsara
changed the title
Member
|
@bsara Thanks! |
Contributor
Author
|
@oliemansm 👍 Thanks for merging the change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the object mapper created using
ObjectMapperProvider&ObjectMapperConfigureris unchanged before use. This includes the default property inclusion value of theObjectMapper. It would never make sense to not have this value be anything other thanJsonInclude.Include.ALWAYSsince GraphQL query results are never to omit any requested property regardless of the value of the property.In a project where both RESTful endpoints and GraphQL are used, the situation may arise where the RESTful endpoints are to omit properties from responses under certain conditions (e.g. omit all
nullvalues from the response). When this is the case and the project uses the sameObjectMapperfor both the RESTful endpoints and theGraphQLServlet, then it would be most helpful to "ignore" the value set by the incomingObjectMapper's default property inclusion value and set it toJsonInclude.Include.ALWAYSinstead.This PR fixes #135