From 883ab9e2fa9190562fdbb0b617bea3a8cc85c858 Mon Sep 17 00:00:00 2001 From: Brandon Sara Date: Wed, 12 Jun 2019 09:56:31 -0600 Subject: [PATCH] separated out logging of errors to separate overridable method in DefaultGraphQLErrorHandler so that entire processErrors method does not need to be overridden just to change which errors get logged by users of DefaultGraphQLErrorHandler --- .../servlet/DefaultGraphQLErrorHandler.java | 20 ++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/main/java/graphql/servlet/DefaultGraphQLErrorHandler.java b/src/main/java/graphql/servlet/DefaultGraphQLErrorHandler.java index 823d43b5..8986c020 100644 --- a/src/main/java/graphql/servlet/DefaultGraphQLErrorHandler.java +++ b/src/main/java/graphql/servlet/DefaultGraphQLErrorHandler.java @@ -26,20 +26,22 @@ public List processErrors(List errors) { errors.stream() .filter(error -> !isClientError(error)) - .forEach(error -> { - if (error instanceof Throwable) { - log.error("Error executing query!", (Throwable) error); - } else if (error instanceof ExceptionWhileDataFetching) { - log.error("Error executing query {}", error.getMessage(), ((ExceptionWhileDataFetching) error).getException()); - } else { - log.error("Error executing query ({}): {}", error.getClass().getSimpleName(), error.getMessage()); - } - }); + .forEach(this::logError); } return clientErrors; } + protected void logError(GraphQLError error) { + if (error instanceof Throwable) { + log.error("Error executing query!", (Throwable) error); + } else if (error instanceof ExceptionWhileDataFetching) { + log.error("Error executing query {}", error.getMessage(), ((ExceptionWhileDataFetching) error).getException()); + } else { + log.error("Error executing query ({}): {}", error.getClass().getSimpleName(), error.getMessage()); + } + } + protected List filterGraphQLErrors(List errors) { return errors.stream() .filter(this::isClientError)