Added some documentation for OSGi & Fix another OSGi deployment issue #22
Conversation
- Renaming the root query and mutation types from "query" and "mutation" to "Query" and "Mutation" to follow object type naming conventions - Modified the GraphQLQueryProvider implementation to make the old API deprecated and replace with a collection of field definitions, making this aligned with the GraphQLMutationProvider interface. This makes it possible to define data fetcher for the root object type fields. - Added JavaDoc documentation to the GraphQLQueryProvider interface
- Modify tests to use new field definition method
… well as provide an example of a GraphQL provider
|
I like the idea, but it might be better to put it in an |
|
Ok should we create this examples directory then ? The problem is that the plugin I need only works with Maven, so I'm not sure how to do this. |
|
I just created it: fb1a37e You can add a subdirectory for your sample and make it as robust as you think it should be - you can make it a maven project and it won't affect the servlet project. |
… that contains a fully running server, as well as an example of GraphQL providers.
sergehuber
changed the title
|
Ok I've completed all the examples I wanted to provide and updated the README accordingly. I also added a fix for the servlet registration in some (older) OSGi containers. The new examples contain a fully running Apache Karaf server package (no binaries, this is generated using a Maven Plugin), that will let users have everything in a single package to get up and running experimenting with GraphQL & OSGi. I've also provided a simple ExampleGraphQLProvider that help see a concrete example. Let me know what you think ! |
|
Wow, this is awesome. Nice work! |
2 participants
Hello,
In this PR I added some documentation for the OSGi providers, as well as an example on how to use an Apache Karaf feature to package all the dependencies for the graphql-java-servlet project, making it (hopefully) easier to get started.
There is also a fix to make it more compatible with other OSGi containers, and also switched to OSGi R6 servlet registration patterns.
Let me know if you need any changes.
Best regards,
Serge...