refactor if statement #343
Conversation
oliemansm
left a comment
oliemansm
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
| if (body == null) { | ||
| body = ""; | ||
| } | ||
| body = body != null ? body : ""; |
There was a problem hiding this comment.
Instead of a null check you could also do body = Optional.ofNullable(body).orElse(""); Although now that I look at this apparently we're re-assigning a parameter here, which isn't good practice to begin with. Besides that it's a pretty strange re-assignment too, since in my opinion it would probably be cleaner if the methods this value is passed to below are able to cope with a null value. That would eliminate the need for this re-assignment completely.
| return Collections.emptyMap(); | ||
| } | ||
| return objectMapper.deserializeVariables(jsonMap); | ||
| return jsonMap != null ? objectMapper.deserializeVariables(jsonMap) : Collections.emptyMap(); |
There was a problem hiding this comment.
This could also be written as
return ofNullable(jsonMap).map(objectMapper::deserializeVariables).orElseGet(emptyMap);But I guess that's just a matter of personal preference :)
There was a problem hiding this comment.
Now I find that your other codes are written as optional.
I think it is better in this case.
Thank you.
refactor if statement into ternary operator
2 participants
Hi I'm glad to find best graphql library for java.
I think in AbstratGraphQLController "if statement" is bad for readability in such simple condition.
It is better to use ternary operator.