Add URI scalar #172
Merged
Add URI scalar #172
+231
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, this pull request has been inactive for 60 days, so we're marking it as stale. If you would like to continue working on this pull request, please make an update within the next 30 days, or we'll close the pull request. |
Contributor
Author
|
May I ask for your opinion about this PR, @dondonz? |
bbakerman
approved these changes
Nov 25, 2025
Member
bbakerman
left a comment
bbakerman
left a comment
There was a problem hiding this comment.
I missed this. Sorry.
Thanks for the contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an URI scalar backed by
java.net.URI.As
java.net.URLmight perform unintended DNS lookups, one could prefer usingURIs instead.https://www.baeldung.com/java-url-vs-uri#3-opening-a-remote-connection
This is a blatant copy of the URL scalar, with necessary adjustments. I can put more effort into it if pointed out.
I've made two commits to make it easier comparing the adjustments: e448bee