Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directive argument name check against directive instead of field #190

Conversation

Projects
None yet
3 participants
@p-guldbaek-elsevier
Copy link
Contributor

commented Aug 22, 2016

The current "KnownArgumentNames" implementation does not take directive arguments into account and verifies all arguments as if they are arguments for fields. It can be worked around (see #16 that suggests adding an "if" argument to fields), but the change suggested in this pull request avoids cluttering the schema.

@arlampin

This comment has been minimized.

Copy link
Contributor

commented Nov 28, 2016

Could this be merged? Currently graphql-java doesn't realistically support directives, as you would need to add all arguments from all directives to all fields where you would like to use those directives.

@dminkovsky

This comment has been minimized.

Copy link
Contributor

commented Dec 11, 2016

Yes, will be fixing this now

@dminkovsky dminkovsky merged commit b549805 into graphql-java:master Dec 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dminkovsky

This comment has been minimized.

Copy link
Contributor

commented Dec 11, 2016

Patch and tests look good. Thank you.

Sorry about the horrible delay here! I had this patched locally and somehow didn't realize this hadn't been merged.

Currently graphql-java doesn't realistically support directives

Yes, yikes. I am going to see about getting this released to Maven soon. Please ping more if other issues are like are not addressed in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.