Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Directive argument name check against directive instead of field #190
The current "KnownArgumentNames" implementation does not take directive arguments into account and verifies all arguments as if they are arguments for fields. It can be worked around (see #16 that suggests adding an "if" argument to fields), but the change suggested in this pull request avoids cluttering the schema.
Patch and tests look good. Thank you.
Sorry about the horrible delay here! I had this patched locally and somehow didn't realize this hadn't been merged.
Yes, yikes. I am going to see about getting this released to Maven soon. Please ping more if other issues are like are not addressed in the future.