Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed grammar: type conditions in inline fragments are optional #275

merged 1 commit into from Dec 18, 2016


None yet
1 participant
Copy link

commented Dec 18, 2016

From #175:

  • Fix a problem with the Antlr grammar for inline fragments. It had this:
    inlineFragment : '...' 'on' typeCondition directives? selectionSet;
    That is the "type condition" (on TypeName) was required. Changed it to be optional, which involved changing the grammar, the way we construct the parse tree and then a bunch of new null checks to deal with the case where the type condition is null.

@dminkovsky dminkovsky merged commit 902681f into graphql-java:master Dec 18, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.