From a8a2f00ab04cc3e4bdcb8a0d39fe6649fab2c194 Mon Sep 17 00:00:00 2001 From: Sebastian Weiss Date: Sat, 29 Dec 2018 22:53:17 +0100 Subject: [PATCH 1/4] improve error handling --- graphene_django/settings.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/graphene_django/settings.py b/graphene_django/settings.py index 7cd750a76..f5003b212 100644 --- a/graphene_django/settings.py +++ b/graphene_django/settings.py @@ -75,6 +75,14 @@ def import_from_string(val, setting_name): e.__class__.__name__, e, ) + if "has no attribute 'name'" in str(e): + object_name = str(e).split("'")[1] + msg = "Could not import '%s' for Graphene setting '%s'. %s: %s must inherit from DjangoObjectType." % ( + val, + setting_name, + e.__class__.__name__, + object_name, + ) raise ImportError(msg) @@ -130,4 +138,4 @@ def reload_graphene_settings(*args, **kwargs): graphene_settings = GrapheneSettings(value, DEFAULTS, IMPORT_STRINGS) -setting_changed.connect(reload_graphene_settings) +setting_changed.connect(reload_graphene_settings) \ No newline at end of file From 60e6f4b7684c4ed5d58266aeeff9d26e799f52ff Mon Sep 17 00:00:00 2001 From: Sebastian Weiss Date: Sat, 29 Dec 2018 22:56:22 +0100 Subject: [PATCH 2/4] lint --- graphene_django/settings.py | 1 - 1 file changed, 1 deletion(-) diff --git a/graphene_django/settings.py b/graphene_django/settings.py index f5003b212..1c5e7296c 100644 --- a/graphene_django/settings.py +++ b/graphene_django/settings.py @@ -137,5 +137,4 @@ def reload_graphene_settings(*args, **kwargs): if setting == "GRAPHENE": graphene_settings = GrapheneSettings(value, DEFAULTS, IMPORT_STRINGS) - setting_changed.connect(reload_graphene_settings) \ No newline at end of file From 23c727d726ab13b5c2fbd6277de70394e08206cc Mon Sep 17 00:00:00 2001 From: Sebastian Weiss Date: Sat, 29 Dec 2018 22:58:23 +0100 Subject: [PATCH 3/4] lint --- graphene_django/settings.py | 1 + 1 file changed, 1 insertion(+) diff --git a/graphene_django/settings.py b/graphene_django/settings.py index 1c5e7296c..f5003b212 100644 --- a/graphene_django/settings.py +++ b/graphene_django/settings.py @@ -137,4 +137,5 @@ def reload_graphene_settings(*args, **kwargs): if setting == "GRAPHENE": graphene_settings = GrapheneSettings(value, DEFAULTS, IMPORT_STRINGS) + setting_changed.connect(reload_graphene_settings) \ No newline at end of file From 9b53db47a50323a3235316fbd1ce80211afe4d13 Mon Sep 17 00:00:00 2001 From: Sebastian Weiss Date: Sat, 29 Dec 2018 23:00:53 +0100 Subject: [PATCH 4/4] lint --- graphene_django/settings.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/graphene_django/settings.py b/graphene_django/settings.py index f5003b212..b6f558cab 100644 --- a/graphene_django/settings.py +++ b/graphene_django/settings.py @@ -138,4 +138,4 @@ def reload_graphene_settings(*args, **kwargs): graphene_settings = GrapheneSettings(value, DEFAULTS, IMPORT_STRINGS) -setting_changed.connect(reload_graphene_settings) \ No newline at end of file +setting_changed.connect(reload_graphene_settings)