Fix for import from graphql-relay-py (#329) #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
=======================================
Coverage 96.91% 96.91%
=======================================
Files 9 9
Lines 616 616
=======================================
Hits 597 597
Misses 19 19
Continue to review full report at Codecov.
|
|
I want to this patch for my production source code to reduce unneeded warning. Any blockers? |
erikwrede
approved these changes
Apr 27, 2022
The module name was deprecated, but all imports should be made from the top level anyway.
erikwrede
force-pushed
the
fix-for-graphql-relay
branch
from
4392985
to
6fe8e6a
Compare
erikwrede
added a commit
to erikwrede/graphene-sqlalchemy
that referenced
this pull request
Jun 9, 2022
….key instead of Column.name, see graphql-python#330 Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
erikwrede
added a commit
that referenced
this pull request
Jul 15, 2022
* Fields generated from Hybrid Properties & Type hints now support Unions (Union[ObjectType1,OT2] or ObjectType1 | OT2) * Support for Variant and types.JSON Columns * BREAKING: Date&Time now convert to their corresponding graphene scalars instead of String. * BREAKING: PG UUID & sqlalchemy_utils.UUIDType now convert to graphene.UUID instead of graphene.String * Change: Sort Enums & ChoiceType enums are now generated from Column.key instead of Column.name, see #330 Signed-off-by: Erik Wrede <erikwrede2@gmail.com> Co-authored-by: Nicolas Delaby <nicolas.delaby@infarm.com> Co-authored-by: davidcim <david@cimaware.com> Co-authored-by: Viktor Pegy <xtpvxt@gmail.com> Co-authored-by: Ian Epperson <ian@epperson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.