Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Upgrade juniper_codegen dependencies #231
@@ Coverage Diff @@ ## master #231 +/- ## ========================================= - Coverage 89.88% 87.29% -2.6% ========================================= Files 95 96 +1 Lines 17945 13943 -4002 ========================================= - Hits 16130 12171 -3959 + Misses 1815 1772 -43
So I changed the initial upgrade commit to keep the structure as before (because you're correct that is the minimal change), but then also added a commit that changes the code to the (simpler, in my mind) direct extend structure again. Feel free to skip that commit if you disagree it's an improvement. Also fixed some typos I found during the fixes.
Thanks! New changes look good to me.
It looks like due to the
regex bump CI fails on Rust 1.21. I think it is worth getting to regex 1.0 and we still work on Rust 1.22 which was released a year ago...so I'm fine dropping 1.21 for this.
The choice is up to you: remove the
regex bump from this PR or remove 1.21 from CI, add 1.23, and add a note to the README and CHANGELOG about new minimum rust requirement.