New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade juniper_codegen dependencies #231

Merged
merged 5 commits into from Aug 27, 2018

Conversation

Projects
None yet
3 participants
@djc
Contributor

djc commented Aug 23, 2018

No description provided.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 23, 2018

Codecov Report

Merging #231 into master will decrease coverage by 2.59%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #231     +/-   ##
=========================================
- Coverage   89.88%   87.29%   -2.6%     
=========================================
  Files          95       96      +1     
  Lines       17945    13943   -4002     
=========================================
- Hits        16130    12171   -3959     
+ Misses       1815     1772     -43
Impacted Files Coverage Δ
juniper_codegen/src/lib.rs 6.25% <ø> (ø) ⬆️
juniper_codegen/src/derive_enum.rs 0% <0%> (ø) ⬆️
juniper_codegen/src/derive_input_object.rs 0% <0%> (ø) ⬆️
juniper_codegen/src/derive_object.rs 0% <0%> (ø) ⬆️
.../src/validation/rules/arguments_of_correct_type.rs 90.46% <0%> (-8.84%) ⬇️
...per/src/validation/rules/fields_on_correct_type.rs 90.9% <0%> (-8.69%) ⬇️
juniper/src/validation/rules/scalar_leafs.rs 91.46% <0%> (-8.54%) ⬇️
juniper/src/tests/schema.rs 70.83% <0%> (-7.74%) ⬇️
...validation/rules/default_values_of_correct_type.rs 92.3% <0%> (-7.7%) ⬇️
.../src/validation/rules/possible_fragment_spreads.rs 93.03% <0%> (-6.97%) ⬇️
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d496220...b41397d. Read the comment docs.

codecov-io commented Aug 23, 2018

Codecov Report

Merging #231 into master will decrease coverage by 2.59%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #231     +/-   ##
=========================================
- Coverage   89.88%   87.29%   -2.6%     
=========================================
  Files          95       96      +1     
  Lines       17945    13943   -4002     
=========================================
- Hits        16130    12171   -3959     
+ Misses       1815     1772     -43
Impacted Files Coverage Δ
juniper_codegen/src/lib.rs 6.25% <ø> (ø) ⬆️
juniper_codegen/src/derive_enum.rs 0% <0%> (ø) ⬆️
juniper_codegen/src/derive_input_object.rs 0% <0%> (ø) ⬆️
juniper_codegen/src/derive_object.rs 0% <0%> (ø) ⬆️
.../src/validation/rules/arguments_of_correct_type.rs 90.46% <0%> (-8.84%) ⬇️
...per/src/validation/rules/fields_on_correct_type.rs 90.9% <0%> (-8.69%) ⬇️
juniper/src/validation/rules/scalar_leafs.rs 91.46% <0%> (-8.54%) ⬇️
juniper/src/tests/schema.rs 70.83% <0%> (-7.74%) ⬇️
...validation/rules/default_values_of_correct_type.rs 92.3% <0%> (-7.7%) ⬇️
.../src/validation/rules/possible_fragment_spreads.rs 93.03% <0%> (-6.97%) ⬇️
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d496220...b41397d. Read the comment docs.

@LegNeato

For all these extend(), can you change them to TokenStream::from()? The old code assigned/replaced and the new code extends/appends. While currently they end up being equivalent, let's preserve the old semantics.

@LegNeato

This comment has been minimized.

Show comment
Hide comment
@LegNeato

LegNeato Aug 26, 2018

Contributor

Thanks for this PR! I was dragging my feat on this and love that you came up with a PR. 🎉

Contributor

LegNeato commented Aug 26, 2018

Thanks for this PR! I was dragging my feat on this and love that you came up with a PR. 🎉

@djc

This comment has been minimized.

Show comment
Hide comment
@djc

djc Aug 27, 2018

Contributor

So I changed the initial upgrade commit to keep the structure as before (because you're correct that is the minimal change), but then also added a commit that changes the code to the (simpler, in my mind) direct extend structure again. Feel free to skip that commit if you disagree it's an improvement. Also fixed some typos I found during the fixes.

Contributor

djc commented Aug 27, 2018

So I changed the initial upgrade commit to keep the structure as before (because you're correct that is the minimal change), but then also added a commit that changes the code to the (simpler, in my mind) direct extend structure again. Feel free to skip that commit if you disagree it's an improvement. Also fixed some typos I found during the fixes.

@LegNeato

Thanks! New changes look good to me.

It looks like due to the regex bump CI fails on Rust 1.21. I think it is worth getting to regex 1.0 and we still work on Rust 1.22 which was released a year ago...so I'm fine dropping 1.21 for this.

The choice is up to you: remove the regex bump from this PR or remove 1.21 from CI, add 1.23, and add a note to the README and CHANGELOG about new minimum rust requirement.

djc added some commits Aug 23, 2018

Simplify construction of new TokenStreams
This foregoes the temporary variables and extends the TokenStream directly,
preventing potentially confusing use of singular/plural variable names.
Stop testing rust-1.21.0, replace with rust-1.23.0
Breaks with the newer dependencies on this branch.
@djc

This comment has been minimized.

Show comment
Hide comment
@djc

djc Aug 27, 2018

Contributor

Replaced 1.21 with 1.23 for Travis CI and added a note to the changelog about it. I couldn't find any mention of the minimum supported Rust version in README, so I left that for now -- would be happy to do a follow-up, though.

Contributor

djc commented Aug 27, 2018

Replaced 1.21 with 1.23 for Travis CI and added a note to the changelog about it. I couldn't find any mention of the minimum supported Rust version in README, so I left that for now -- would be happy to do a follow-up, though.

@LegNeato LegNeato merged commit 62d015c into graphql-rust:master Aug 27, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment