Loosen up BatchLoadFn TS definition, Promise -> PromiseLike #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given than DataLoader only checks that a batch loader is "thenable", changing the TS def from
Promise<Array<V | Error>>
toPromiseLike<Array<V | Error>>
better matches the intent - any object which matches the promise.then
signature.This is useful when returning promises from Bluebird, which utilizes the
PromiseLike
interface but doesn't conform to theSymbol.toStringTag
TypeScript uses to check for thePromise
type.Otherwise I find myself wrapping the Bluebird promises in an extra
Promise.resolve
just to type-check.