From 83364b28020b5946ed58908d6d977f1de766e75d Mon Sep 17 00:00:00 2001 From: Thomas Heyenbrock Date: Tue, 15 Nov 2022 13:31:15 +0100 Subject: [PATCH] add missing effect dep for default headers (#2912) --- .changeset/red-ligers-scream.md | 6 ++++++ packages/graphiql-react/src/editor/context.tsx | 8 +++++++- 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 .changeset/red-ligers-scream.md diff --git a/.changeset/red-ligers-scream.md b/.changeset/red-ligers-scream.md new file mode 100644 index 00000000000..299ff5e7a8d --- /dev/null +++ b/.changeset/red-ligers-scream.md @@ -0,0 +1,6 @@ +--- +'@graphiql/react': patch +--- + +Add missing effect dependency to make sure updates to the `defaultHeaders` prop +have the desired effect diff --git a/packages/graphiql-react/src/editor/context.tsx b/packages/graphiql-react/src/editor/context.tsx index 1eafd584db2..c141df63e85 100644 --- a/packages/graphiql-react/src/editor/context.tsx +++ b/packages/graphiql-react/src/editor/context.tsx @@ -329,7 +329,13 @@ export function EditorContextProvider(props: EditorContextProviderProps) { onTabChange?.(updated); return updated; }); - }, [onTabChange, setEditorValues, storeTabs, synchronizeActiveTabValues]); + }, [ + props.defaultHeaders, + onTabChange, + setEditorValues, + storeTabs, + synchronizeActiveTabValues, + ]); const changeTab = useCallback( index => {